Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4243] Tweaks to the new var-dumper component #4424

Merged
merged 2 commits into from
Nov 13, 2014
Merged

Conversation

weaverryan
Copy link
Member

Q A
Doc fix? yes
New docs? no
Applies to 2.6
Fixed tickets none

Hi guys!

This follows after #4243 - the best way to review it was to merge, read from scratch, and make these final tweaks. As always, I've certainly made some mistakes, so I appreciate the review.

Thanks!

@weaverryan weaverryan mentioned this pull request Nov 5, 2014
6 tasks
Calls to ``dump()`` will then be forwarded to ``$callable``.

By adding a handler, you can customize the `Cloners`_, `Dumpers`_ and `Casters`_
explained below. A simple implementation of a handler function might look
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"as" missing?

@nicolas-grekas
Copy link
Member

Thanks for the merge and the fixes!
@wouterj suggested moving the "DebugBundle and Twig Integration" section in an other page,
maybe for this PR?

@nicolas-grekas
Copy link
Member

I don't see the images on http://symfony.com/doc/master/components/var_dumper/introduction.html
Did I miss something?

@wouterj
Copy link
Member

wouterj commented Nov 5, 2014

I'll do another pr after this is merged with my fixes.

The images will be shown after the complete build, which happen at 3 or 4 AM european time

@nicolas-grekas
Copy link
Member

You can cherry-pick https://github.com/nicolas-grekas/symfony-docs/tree/var-dumper-tweaks for fixing my above comments

@xabbuh
Copy link
Member

xabbuh commented Nov 13, 2014

FYI, I applied the tweaks suggested by @nicolas-grekas.

@weaverryan
Copy link
Member Author

Wow guys, quit making my job so easy :p. Seriously, I just did no work and we have these great updates. Thanks!

@weaverryan weaverryan merged commit 1a29f24 into master Nov 13, 2014
weaverryan added a commit that referenced this pull request Nov 13, 2014
…yan, nicolas-grekas)

This PR was merged into the master branch.

Discussion
----------

[#4243] Tweaks to the new var-dumper component

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.6
| Fixed tickets | none

Hi guys!

This follows after #4243 - the best way to review it was to merge, read from scratch, and make these final tweaks. As always, I've certainly made some mistakes, so I appreciate the review.

Thanks!

Commits
-------

1a29f24 typos in the var-dumper component
265604b [#4243] Tweaks to the new var-dumper component
@weaverryan weaverryan deleted the var-dumper-tweaks branch November 13, 2014 16:47
@weaverryan
Copy link
Member Author

Hey guys!

I merged this into the new master instead of 2.6. So just an FYI, this is now in 2.6 at sha: 17c6cac and sha: a79196a

Thanks!

@wouterj
Copy link
Member

wouterj commented Dec 7, 2014

@weaverryan could you please also cherry pick the merge commit? (or do an empty commit with the same message as the merge commit) This way, the changelog will generates itself correctly 🐤

wouterj added a commit that referenced this pull request Feb 14, 2015
This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #4977).

Discussion
----------

Unnecessary comma

Commits
-------

8a2f0ba Wrong comma
81e8c13 Merge branch '2.7'
ef39a01 Remove diff
8d56ad7 Merge branch '2.7'
6fd286b Added January changelog
ad97700 Merge branch '2.7'
c0f9f67 Merge branch '2.7'
87eb36c Merge branch '2.7'
714f630 Merge branch '2.7'
99e2996 Merge branch '2.7'
c33b371 Merge branch '2.7'
6c498d4 feature #4805 added documentation for the new absolute_url() and relative_path() Twig functions (fabpot)
e4d22f0 added documentation for the new absolute_url() and relative_path() Twig functions
907ee0d Merge branch '2.7'
a17bdd7 Merge branch '2.7'
ca3b4c8 feature #4753 bump Symfony requirements to PHP 5.5 (xabbuh)
9919bca Revert "Fixed markup"
c859790 Fixed markup
032a6b4 Merge branch '2.7'
92b10b1 bug #4758 [Components][Yaml] don't describe removed usage of Yaml::parse() (xabbuh)
42d2b15 Merge branch '2.7'
6f9832d Merge branch '2.7'
d33b78b don't describe removed usage of Yaml::parse()
bcab77b bump Symfony requirements to PHP 5.5
6ef6a04 Merge branch '2.7'
fcfea43 Merge branch '2.7'
353995e Merge branch '2.7'
27296ad Merge branch '2.7'
56db7af Merge branch '2.7'
9e5fc6c Merge branch '2.7'
cb6f846 Merge branch '2.7'
8131844 Merge branch '2.7'
2fcebc1 Merge branch '2.7'
07aa543 Merge branch '2.7'
4056218 Merge branch '2.7'
0906e0c Merge branch '2.7'
e539bd1 Merge branch '2.7'
2d1c336 Merge branch '2.7'
d30dc9e Merge remote-tracking branch 'origin/master'
3454883 Merge branch '2.7'
f0ac8bb Merge branch '2.7'
d921dcd Merge branch '2.7'
486baf8 Merge branch '2.7'
8099ac1 Merge branch '2.7'
6b73990 Merge branch '2.7'
0fb81cc Merge branch '2.7'
d969e8b Merge branch '2.7'
f24b645 Merge branch '2.7'
d6ce29f Merge branch '2.7'
51224e9 Merge branch '2.7'
0c92fab Merge branch '2.7'
0d5cb0d Merge branch '2.7'
3329bd2 feature #4424 [#4243] Tweaks to the new var-dumper component (weaverryan, nicolas-grekas)
9caea6f feature #4336 [Form] Add entity manager instance support for em option (egeloen)
1a29f24 typos in the var-dumper component
09a6fd7 [Form] Add entity manager instance support for em option
265604b [#4243] Tweaks to the new var-dumper component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants