Add missing autoload include in basic console application example #4641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
senkal
commented
Dec 12, 2014
senkal
commented
| Q | A |
|---|---|
| Doc fix? | [yes] |
| New doc | [no] |
| Applies to | all |
| Fixed tick |
| @@ -88,6 +88,8 @@ an ``Application`` and adds commands to it:: | |||
| <?php | |||
| // application.php | |||
|
|
|||
| require __DIR__ . '/vendor/autoload.php'; | |||
There was a problem hiding this comment.
Can you please remove the spaces around the dot to comply with Symfony's CS?
|
I think the change is reasonable to complete the code example. 👍 @senkal Can you fix my minor comment? |
|
@xabbuh Done. |
|
Ah, nice catch - you're absolutely right. Thanks Marcin! |
weaverryan
added a commit
that referenced
this pull request
Dec 22, 2014
…xample (senkal) This PR was merged into the 2.3 branch. Discussion ---------- Add missing autoload include in basic console application example | Q | A | ------------------- | --- | Doc fix? | [yes] | New doc | [no] | Applies to | all | Fixed tick | Commits ------- f6fac50 Fix for symfony code standards 6f56270 Add missing autoload include in basic application example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.