Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewritten from scratch the chapter about installing Symfony #4654

Merged
merged 10 commits into from
Dec 20, 2014

Conversation

javiereguiluz
Copy link
Member

Q A
Doc fix? yes
New docs? yes
Applies to all
Fixed tickets #4122, #4089

The installer requires PHP 5.4 or higher. If you still use the legacy
PHP 5.3 version, you cannot use the Symfony Installer. In that case, read the next
:ref:`Creating Symfony Applications without the Installer <book-creating-applications-without-the-installer>`
section.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sentence In that case, read the next Creating Symfony Applications without the Installer section looks weird IMO

---------------------------------
The installer requires PHP 5.4 or higher. If you still use the legacy
PHP 5.3 version, you cannot use the Symfony Installer. Read
:ref:`Creating Symfony Applications without the Installer <book-creating-applications-without-the-installer>`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change this sentence to this ("the" is missing, the ref label is not needed and "know" doesn't seem to be the right word to me):

Read the :ref:`book-creating-applications-without-the-installer` section to learn how to proceed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your proposal is much better. Thanks!

@xabbuh
Copy link
Member

xabbuh commented Dec 17, 2014

Looks great, Javier! 👍

@weaverryan
Copy link
Member

Thank god for this - I will review shortly (I just ran out of time right now). I don't think that the plans I laid out in #4672 nullify this, I actually think this will be a major step forward towards that.

@weaverryan weaverryan merged commit 7de83a3 into symfony:2.3 Dec 20, 2014
weaverryan added a commit that referenced this pull request Dec 20, 2014
…fony (javiereguiluz)

This PR was merged into the 2.3 branch.

Discussion
----------

Rewritten from scratch the chapter about installing Symfony

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | yes
| Applies to    | all
| Fixed tickets | #4122, #4089

Commits
-------

7de83a3 Replaced a "note" by a "seealso"
b45c338 Imrpoved the wording of the note about using using legacy PHP 5.3 version
40d7772 Reworded the reasons why you should use Composer-based installation
2e72138 Wrapped a line to follow doc standards
7e9cd04 Display the same version number on Linux and Windows to avoid confusions
12c2557 Add an explicit command to better explain that we recommend to move symfony.phar to projects directory
12eb76e Reworded a confusing phrase
b665d86 Added a note about verifying Symfony digital signatures
8f202c6 Re-added a wrongly deleted link reference
c291a73 Rewritten from scratch the chapter about installing Symfony
@weaverryan
Copy link
Member

Thanks so much Javier! When I created my list for #4672, this was - by far - the ugliest and worst todo on that list. I think we can take another look at it once the new download page is there, but it's already many times better than before.

Cheers!

@javiereguiluz javiereguiluz deleted the update_installation_instructions branch February 18, 2015 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants