consistent spelling #4671

xabbuh · 2014-12-19T18:01:15Z

Q	A
Doc fix?	no
New docs?	no
Applies to	all
Fixed tickets	#3237

stof · 2014-12-22T12:45:42Z

components/config/definition.rst

@@ -13,7 +13,7 @@ Component. Configuration values are usually expected to show some kind of
 hierarchy. Also, values should be of a certain type, be restricted in number
 or be one of a given set of values. For example, the following configuration
 (in YAML) shows a clear hierarchy and some validation rules that should be
-applied to it (like: "the value for ``auto_connect`` must be a boolean value"):
+applied to it (like: "the value for ``auto_connect`` must be a Boolean value"):


should the adjective have a capital letter too ?

At least, that's how Wikipedia uses it (I also think that this make sense since it's based on George Boole's name).

this should be reverted to lowercase, just like the rest of the occurences

hmm, there are more Boolean occurences. Looks like you didn't replace them to be lowercase

still goes wrong here, @xabbuh (seems like all "boolean" occurences are replaced with "Boolean" and all "Boolean" with "boolean")

Agreed - the PR has a mix of changes right now. irrc, we've started using the lowercase version in core, but I'm not sure.

core has switched to bool to support Hack. I'm still voting for "boolean"

wouterj · 2014-12-22T13:14:17Z

Do we really want Boolean? I really don't like it as it's inconsistent.

xabbuh · 2014-12-22T13:30:30Z

@wouterj I think it make sense in terms that it is derived from George Boole's name. We also used Boolean in quite a lot of places in the reference for option types. Though I don't have any strong feelings about this. If you all think that boolean feels more natural, I'll revert the changes and convert uppercased occurences with lowercased ones.

By the way, why do we use Boolean in the reference at all and don't use bool like the Symfoy code base does? Is it just for historical reasons?

javiereguiluz · 2014-12-22T13:51:20Z

@xabbuh I agree with @wouterj: even if Boolean is the correct term, most developers use it as boolean and treat it as a common word.

xabbuh · 2014-12-22T14:33:29Z

Seems we have a majority for boolean instead of Boolean then. :) Have replaced them accordingly.

wouterj · 2014-12-22T15:38:52Z

@xabbuh the code changed this year to bool instead of Boolean (that's where the capitialized boolean in the docs come from), to make their types compatible with Hack (http://docs.hhvm.com/manual/en/hack.annotations.types.php).

I don't think bool is as clear as boolean, that's why I propose to keep using boolean instead of bool

xabbuh · 2014-12-22T15:45:37Z

@wouterj Thanks for the explanation. So, should we now keep lowercased boolean everywhere or switch it back to Boolean in the reference and use boolean in texts only?

wouterj · 2014-12-22T15:52:41Z

I think we should use boolean (lowercased) everywhere.

xabbuh · 2014-12-29T20:42:31Z

This is ready to be reviewed now. I've kept different commits for each item of the task list so that you can review each step on its own.

However, there are two changes I'm not completely happy with:

Unifying occurrences of Symfony framework and Symfony Framework to always use the latter on is probably a good idea. But we also have a lot of occurrences of "Symfony full-stack Framework" now which looks a bit weird. Should we keep it anyway? Or replace it with something like "full-stack Symfony Framework" or "Symfony Full-Stack Framework"?
I don't like using uppercase letters for "Dependency Injection". Why don't we write "dependency injection container", "dependency injection tags" and "dependency injection extension class" while keeping uppercase letters only for the "DependencyInjection component"?

javiereguiluz · 2015-02-19T13:52:27Z

@xabbuh regarding your questions:

I prefer using this variant: full-stack Symfony Framework
I agree with you about lowercasing dependency injection except when referring to the component.

Do you think this PR could be merged anytime soon? It looks like we're very close thanks to your great work and it's sad to see these nice improvements pending to be merged. Thanks.

xabbuh · 2015-02-19T14:19:15Z

@javiereguiluz This can be merged once we agree on all the changes. :) Though I'm fine with splitting it in several PRs if there are some things that should be discussed while others may be settled.

@wouterj @weaverryan What do you think?

wouterj · 2015-02-21T10:10:08Z

+1 for Symfony Full-Stack Framework
+1 for lowercase dependency injection and only capitialized when talking about the component

Btw, thsi also needs a rebase.

wouterj · 2015-02-21T10:10:48Z

book/forms.rst

@@ -1519,7 +1519,7 @@ file, you can see every block needed to render a form and every default field
 type.

 In PHP, the fragments are individual template files. By default they are located in
-the `Resources/views/Form` directory of the framework bundle (`view on GitHub`_).
+the `Resources/views/Form` directory of the FrameworkBundle (`view on GitHub`_).


this should be double backticks

Do we do this anywhere else with bundle names?

sorry, I meant the resoruces/views/form at the start of the line

Oh, of course. Totally missed that. Thanks for noticing. 👍

wouterj · 2015-04-30T15:31:44Z

This PR still contains the boolean mix up.

xabbuh · 2015-05-01T08:38:19Z

I rebased and finally fixed the boolean/Boolean mix up.

wouterj · 2015-05-21T14:16:58Z

Let's merge this one to avoid more conflicts :)

weaverryan · 2015-05-22T01:24:34Z

WOW @xabbuh. And not even any conflicts :). Thanks for the long work on this!

This PR was merged into the 2.3 branch. Discussion ---------- consistent spelling | Q | A | ------------- | --- | Doc fix? | no | New docs? | no | Applies to | all | Fixed tickets | #3237 - [x] stylesheet - Stylesheet - [x] front-end - frontend - front end - [x] Full-Stack - Full stack - [x] Symfony2 Framework - form framework - Form framework - [x] Save-handler - Save handler - [x] Dependeny Injection Tags - Dependeny Injection Container - dependeny injection container - [x] Event Dispatcher - event dispatcher - [x] Event Subscriber - event subscriber - [x] Symfony2 Standard Distribution - Symfony2 Standard Edition - [x] Console Command - console command - [x] email - Email - e-mail - [x] Boolean - boolean - [x] web debug toolbar - Web Debug Toolbar - [x] Exception - exception - [x] object-oriented - object oriented Commits ------- f182121 uppercase "dependency injection" 6b7d536 use "Symfony Framework" instead of "Symfony framework" 07bc4db use "Form component" instead of "form framework" bd5ca26 use "full-stack" instead of "full stack" 5b6895a unify exception usages b774651 unify event subscriber usages 95c842c use "console command" instead of "Console Command" 9c02eda unify EventDispatcher/event dispatcher usages fd52cd3 use boolean instead of Boolean f8db4b0 use "object-oriented" instead of "object oriented" 1bd33ca "web debug toolbar" instead of "Web Debug Toolbar" b2d802e use "stylesheet" instead of "Stylesheet" 7eb1847 unify "Symfony Standard Edition" usages 85fb0b1 consistency, replace "save-handler" with "save handler" 83238aa consisteny, use "front-end" instead of "frontend" or "front end" 5b8e84d consistency, replace "e-mail" with "email"

xabbuh added the Status: Needs Work label Dec 22, 2014

stof reviewed Dec 22, 2014
View reviewed changes

xabbuh force-pushed the issue-3237 branch from d906731 to 84ba5b6 Compare December 22, 2014 13:51

xabbuh force-pushed the issue-3237 branch 2 times, most recently from d906731 to c09ba41 Compare December 22, 2014 13:56

xabbuh force-pushed the issue-3237 branch from 58d6826 to 5a8f8c1 Compare December 29, 2014 19:03

xabbuh changed the title ~~[WIP] consistent spelling~~ consistent spelling Dec 29, 2014

xabbuh force-pushed the issue-3237 branch from df2eade to a0f1a50 Compare December 29, 2014 20:44

xabbuh added the needs comments label Dec 31, 2014

xabbuh force-pushed the issue-3237 branch from a0f1a50 to 22264e4 Compare January 11, 2015 11:08

xabbuh mentioned this pull request Feb 3, 2015

Fixes for 2.3 branch #4956

Closed

wouterj mentioned this pull request Feb 6, 2015

Code style standardization on form type options #4967

Closed

wouterj reviewed Feb 21, 2015
View reviewed changes

xabbuh added 6 commits May 1, 2015 10:01

consistency, replace "e-mail" with "email"

5b8e84d

consisteny, use "front-end" instead of "frontend" or "front end"

83238aa

consistency, replace "save-handler" with "save handler"

85fb0b1

unify "Symfony Standard Edition" usages

7eb1847

use "stylesheet" instead of "Stylesheet"

b2d802e

"web debug toolbar" instead of "Web Debug Toolbar"

1bd33ca

xabbuh force-pushed the issue-3237 branch 2 times, most recently from 24eba9c to f0e0663 Compare May 1, 2015 08:27

use "object-oriented" instead of "object oriented"

f8db4b0

xabbuh force-pushed the issue-3237 branch from f0e0663 to 79d6007 Compare May 1, 2015 08:29

Christian Flothmann and others added 9 commits May 1, 2015 10:37

use boolean instead of Boolean

fd52cd3

unify EventDispatcher/event dispatcher usages

9c02eda

use "console command" instead of "Console Command"

95c842c

unify event subscriber usages

b774651

unify exception usages

5b6895a

use "full-stack" instead of "full stack"

bd5ca26

use "Form component" instead of "form framework"

07bc4db

use "Symfony Framework" instead of "Symfony framework"

6b7d536

uppercase "dependency injection"

f182121

xabbuh force-pushed the issue-3237 branch from 79d6007 to f182121 Compare May 1, 2015 08:37

wouterj added Status: Reviewed and removed Status: Needs Work needs comments labels May 21, 2015

weaverryan merged commit f182121 into symfony:2.3 May 22, 2015

xabbuh deleted the issue-3237 branch May 22, 2015 05:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

consistent spelling #4671

consistent spelling #4671

xabbuh commented Dec 19, 2014

stof Dec 22, 2014

xabbuh Dec 22, 2014

wouterj Feb 21, 2015

wouterj Feb 21, 2015

wouterj Feb 24, 2015

weaverryan Mar 15, 2015

wouterj Mar 15, 2015

wouterj commented Dec 22, 2014

xabbuh commented Dec 22, 2014

javiereguiluz commented Dec 22, 2014

xabbuh commented Dec 22, 2014

wouterj commented Dec 22, 2014

xabbuh commented Dec 22, 2014

wouterj commented Dec 22, 2014

xabbuh commented Dec 29, 2014

javiereguiluz commented Feb 19, 2015

xabbuh commented Feb 19, 2015

wouterj commented Feb 21, 2015

wouterj Feb 21, 2015

xabbuh Feb 21, 2015

wouterj Feb 21, 2015

xabbuh Feb 21, 2015

wouterj commented Apr 30, 2015

xabbuh commented May 1, 2015

wouterj commented May 21, 2015

weaverryan commented May 22, 2015

consistent spelling #4671

consistent spelling #4671

Conversation

xabbuh commented Dec 19, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wouterj commented Dec 22, 2014

xabbuh commented Dec 22, 2014

javiereguiluz commented Dec 22, 2014

xabbuh commented Dec 22, 2014

wouterj commented Dec 22, 2014

xabbuh commented Dec 22, 2014

wouterj commented Dec 22, 2014

xabbuh commented Dec 29, 2014

javiereguiluz commented Feb 19, 2015

xabbuh commented Feb 19, 2015

wouterj commented Feb 21, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wouterj commented Apr 30, 2015

xabbuh commented May 1, 2015

wouterj commented May 21, 2015

weaverryan commented May 22, 2015