Use AppBundle whenever it's possible #4740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
@javiereguiluz Great work! 👍 |
This was referenced Jan 15, 2015
Closed
|
WOW, this is a massive amount of work - thanks so much Javier! It's also a big leap of faith - I can see all the changes, but if we're missing anything, we can't see those. But it seems like you were quite careful - I see you catching web/bundles/* symlink names, service names and more. And there's no way we can be more sure than this. So, I'm merging this in and we'll keep moving from here. Yay! |
weaverryan
added a commit
that referenced
this pull request
Jan 16, 2015
This PR was merged into the 2.3 branch. Discussion ---------- Use AppBundle whenever it's possible | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3+ | Fixed tickets | - This PR replaces `AcmeFooBundle`, `AcmeHelloBundle` and `AcmeDemoBundle` by `AppBundle` whenever it's possible in the Cookbook. This is the first step into making the cookbook compliant with the recent good practices promoted by Symfony (the book is being made compliant in #4431). If we change everything to comply with the good practices, the pull request will be massive and it will take months. That's why I think it's better to do it in several steps using different pull requests. By the way, this PR also contains some minor tweaks about using the new `app/config/services.yml` file. I can revert those changes if you want it. Commits ------- c6580f8 Use AppBundle whenever it's possible
c960657
pushed a commit
to c960657/symfony-docs
that referenced
this pull request
Jan 29, 2015
This brings the class names back in sync after the change in PR symfony#4740.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces
AcmeFooBundle,AcmeHelloBundleandAcmeDemoBundlebyAppBundlewhenever it's possible in the Cookbook.This is the first step into making the cookbook compliant with the recent good practices promoted by Symfony (the book is being made compliant in #4431). If we change everything to comply with the good practices, the pull request will be massive and it will take months. That's why I think it's better to do it in several steps using different pull requests.
By the way, this PR also contains some minor tweaks about using the new
app/config/services.ymlfile. I can revert those changes if you want it.