Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Components][ClassLoader] remove DebugClassLoader #4855

Closed
wants to merge 3 commits into from

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jan 16, 2015

Q A
Doc fix? no
New docs? no
Applies to 3.0+
Fixed tickets

The DebugClassLoader has been moved to the Debug component with
Symfony 2.4 and will be removed in 3.0 (see symfony/symfony#13203).

@xabbuh
Copy link
Member Author

xabbuh commented Jan 16, 2015

It seems that we don't have docs for ApcUniversalClassLoader, DebugUniversalClassLoader and UniversalClassLoader.

@wouterj
Copy link
Member

wouterj commented Jan 16, 2015

You forgot to remove the links from components/class_loader/introduction.rst

@stof
Copy link
Member

stof commented Jan 16, 2015

@xabbuh these 3 classes are deprecated. So I don't think we really need to document them

.. index::
single: ClassLoader; DebugClassLoader

Debugging a Class Loader
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The url of this page should be added in the redirection map (the only reason why it was done this way rather than removing the page was that because symfony.com was not supporting different redirections per versions of the doc, so it was impossible to remove the page)

@stof
Copy link
Member

stof commented Jan 16, 2015

I suggest removing this page in older versions

ifdattic and others added 3 commits January 31, 2015 11:21
This PR was squashed before being merged into the 2.5 branch (closes symfony#4944).

Discussion
----------

Fix formatting

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.5
| Fixed tickets |

Commits
-------

6572fea Fix formatting
The `DebugClassLoader` has been moved to the Debug component with
Symfony 2.4 and will be removed in 3.0 (see symfony/symfony#13203).
@xabbuh
Copy link
Member Author

xabbuh commented Jan 31, 2015

Closing in favor of #4947.

@xabbuh xabbuh closed this Jan 31, 2015
weaverryan added a commit that referenced this pull request Jun 9, 2015
This PR was submitted for the 2.5 branch but it was merged into the 2.6 branch instead (closes #4947).

Discussion
----------

[Components][ClassLoader] remove DebugClassLoader

| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | no
| Applies to    | 2.5
| Fixed tickets |

The `DebugClassLoader` has been moved to the Debug component with
Symfony 2.4 and will be removed in 3.0 (see symfony/symfony#13203).

This replaced #4855 by removing the `DebugClassLoader` docs from ClassLoader component in the 2.5 version, but keeping a redirect to the description in the Debug component. The redirection map entry should then be removed once the changes got merged up into the `master` branch.

Commits
-------

73e9833 [Components][ClassLoader] remove DebugClassLoader
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants