Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the Stable API chapter from the Symfony book #4902

Merged

Conversation

javiereguiluz
Copy link
Member

Q A
Doc fix? no
New docs? no
Applies to all
Fixed tickets -

The two main reasons for this change are: 1) the traffic to that book chapter is almost zero; 2) all the things explained in this "chapter" are better explained in the BC Promise article. A redirection to that article has been setup.

@wouterj
Copy link
Member

wouterj commented Jan 23, 2015

The chapter does however not list the components which have a stable API. We should add that list imo

@stof
Copy link
Member

stof commented Jan 23, 2015

@wouterj the list is totally outdated though

@javiereguiluz
Copy link
Member Author

@wouterj I don't understand your comment. If you say that the removed chapter contains wrong information ... well it doesn't matter because we're removing the chapter.

If you mean that the BC Promise article doesn't list the components with stable API, I guess we can tackle that in another issue.

@stof
Copy link
Member

stof commented Jan 23, 2015

This list is not necessary anymore IMO. It was useful at the time where we were providing BC only for some components. But as of Symfony 2.3, the BC promise covers all components

@wouterj
Copy link
Member

wouterj commented Jan 23, 2015

@stof yeah, but the BC promise is quite a lot stricter for stable API components than for non stable API components.

@javiereguiluz I indeed meant to move the list to the bc article. Why doing that in another PR, isn't it a very simple change?

@stof
Copy link
Member

stof commented Jan 23, 2015

@wouterj but giving a list of components with a tagged stable API does not help much. Most components have it, and this does not mean that everything is tagged as such in the component. It is not a component-level flagging but a class-level one.

@wouterj
Copy link
Member

wouterj commented Jan 31, 2015

Okay 👍

@weaverryan
Copy link
Member

Thanks Javier!

@weaverryan weaverryan merged commit 42269d4 into symfony:2.3 Feb 1, 2015
weaverryan added a commit that referenced this pull request Feb 1, 2015
…aviereguiluz)

This PR was merged into the 2.3 branch.

Discussion
----------

Removed the Stable API chapter from the Symfony book

| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | no
| Applies to    | all
| Fixed tickets | -

The two main reasons for this change are: 1) the traffic to that book chapter is almost zero; 2) all the things explained in this "chapter" are better explained in the BC Promise article. A redirection to that article has been setup.

Commits
-------

42269d4 Removed the Stable API chapter from the Symfony book
@javiereguiluz javiereguiluz deleted the book_remove_stable_api_chapter branch February 18, 2015 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants