[Reference] Add missing option delivery_whitelist #5056
Conversation
TerjeBr
commented
Mar 2, 2015
TerjeBr
commented
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | SwiftMailerBundle 2.1 |
| Fixed tickets | #4925 |
Q | A -------- Doc fix? | yes New docs? | no Applies to | SwiftMailerBundle 2.1 Fixed tickets | no
|
Added this PR since @e-weimann just closed his PR #4925 without it being merged. |
| @@ -156,6 +157,17 @@ emails sent during development go to a single account. | |||
| This uses ``Swift_Plugins_RedirectingPlugin``. Original recipients are available | |||
| on the ``X-Swift-To``, ``X-Swift-Cc`` and ``X-Swift-Bcc`` headers. | |||
|
|
|||
| delivery_whitelist | |||
| +~~~~~~~~~~~~~~~~~~ | |||
There was a problem hiding this comment.
You have to remove the plus characters you copied from the old PR's diff. :)
There was a problem hiding this comment.
Yes, forgot that. Done that now.
|
|
||
| Used in combination with ``delivery_address``. If set, emails matching any of these | ||
| patterns will be delivered like normal, instead of being sent to `delivery_address`. | ||
| For details, see `the Cookbook entry.`_ |
There was a problem hiding this comment.
Please use the ref role for internal links like this:
:ref:`the cookbook entry <sending-to-a-specified-address-but-with-exceptions>`
|
@TerjeBr Can you please also add the label in It should look like this (around line 122): .. _sending-to-a-specified-address-but-with-exceptions:
Sending to a Specified Address but with Exceptions
.................................................. |
| **type**: ``array`` | ||
|
|
||
| Used in combination with ``delivery_address``. If set, emails matching any of these | ||
| patterns will be delivered like normal, instead of being sent to `delivery_address`. |
There was a problem hiding this comment.
sorry, one last thing: you have to use double backticks for inline codeblocks in reStructured text.
|
Looking good, thanks! 👍 |
|
👍 I like it. And a huge thank you to @e-weimann for the initial work on this. |
|
@e-weimann opened #4925 just after I had filed #4924 . I did the initial work of documenting this feature, and I also provided @e-weimann with the text for the reference update. But I guess we can thank @e-weimann for taking the initiative to help us not letting the reference section be forgotten on this issue. |
|
Thanks very much to both of you (@TerjeBr and @e-weimann) for making sure this cool little feature got its docs. Like I said on the original PR, I didn't even know this existed! Cheers! |
…eBr) This PR was merged into the 2.3 branch. Discussion ---------- [Reference] Add missing option delivery_whitelist Q | A ---|--- Doc fix? | yes New docs? | no Applies to | SwiftMailerBundle 2.1 Fixed tickets | #4925 Commits ------- 03279dc Added double backticks. And also a full stop. 2aab241 added link target/label in the cookbook ce8719d Changed link into ref 07855f6 Removed + from copied diff 0195619 [Reference] Add missing option delivery_whitelist
