Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Contributing][Code] link to deciders' GitHub profiles #5079

Merged
merged 1 commit into from
Mar 14, 2015

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Mar 12, 2015

Q A
Doc fix? no
New docs? no
Applies to all
Fixed tickets

I thought it would be a good idea to be able to easily access the GitHub profiles of the core team members.

@javiereguiluz
Copy link
Member

In the past, the special RST scopes were used because the tool used to merge PRs may use them to extract the information about deciders/mergers and decide if a PR could be merged. However, that tool hardcodes this information in its source code, so this information is no longer needed in this page and I think it's OK to remove it. So 👍 and thanks you for this improvement.

@xabbuh
Copy link
Member Author

xabbuh commented Mar 12, 2015

In the past, the special RST scopes were used because the tool used to merge PRs may use them to extract the information about deciders/mergers and decide if a PR could be merged.

Ah, I didn't know that. Thanks for clarifying the initial reasons for this.

However, that tool hardcodes this information in its source code, so this information is no longer needed in this page and I think it's OK to remove it.

This sounds good. :)

@weaverryan
Copy link
Member

Huh, I didn't know about those scopes either :). Looks like a fine idea to me. Thanks Christian!

@weaverryan weaverryan merged commit 7fc1145 into symfony:2.3 Mar 14, 2015
weaverryan added a commit that referenced this pull request Mar 14, 2015
…abbuh)

This PR was merged into the 2.3 branch.

Discussion
----------

[Contributing][Code] link to deciders' GitHub profiles

| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | no
| Applies to    | all
| Fixed tickets |

I thought it would be a good idea to be able to easily access the GitHub profiles of the core team members.

Commits
-------

7fc1145 link to deciders' GitHub profiles
@xabbuh xabbuh deleted the link-core-team-profiles branch March 15, 2015 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants