Updated Cookies & Caching section #5188
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct code for Varnish 4 (unset instead of remove)
| .. code-block:: varnish4 | ||
| .. configuration-block:: | ||
|
|
||
| .. code-block:: varnish4 | ||
|
|
||
| sub vcl_recv { |
There was a problem hiding this comment.
The code block itself now needs to be indented by four spaces.
|
This pull request looks ready to be merged. |
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
This blank line should be removed.
|
according to the varnish changelog remove was indeed replaced by unset in varnish 4. the wiki page where this example comes from seems to not be updated... |
|
This PR can be labeled as finished because @dbu verified the proposed changes and the reamining blank line can be removed during the merge process. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct code for Varnish 4 (unset instead of remove)