Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing link in "Sections" #5200

Merged
merged 1 commit into from
Apr 26, 2015
Merged

Added missing link in "Sections" #5200

merged 1 commit into from
Apr 26, 2015

Conversation

sfdumi
Copy link
Contributor

@sfdumi sfdumi commented Apr 21, 2015

No description provided.

@xabbuh
Copy link
Member

xabbuh commented Apr 21, 2015

Thank for your trying to improve the docs, @sfdumi. However, if I am not mistaken this has already been added in 614da15. Could it be that you had a look at an outdated fork of the repository? So I'm going to close here for the moment, but please feel free to reopen if I misunderstood anything.

@xabbuh xabbuh closed this Apr 21, 2015
@wouterj
Copy link
Member

wouterj commented Apr 21, 2015

@xabbuh that commit is about the map and index files. This PR is about adding the link under the "Sections" title in the introduction article. It was indeed forgotten to add this link there.

So I'm going to reopen this and will merge it later this week. Thanks already @sfdumi!

@wouterj wouterj reopened this Apr 21, 2015
@xabbuh
Copy link
Member

xabbuh commented Apr 21, 2015

Oh indeed, thanks for clarifying @wouterj.

@wouterj
Copy link
Member

wouterj commented Apr 26, 2015

Let's merge this one quickly to avoid more confusion :) Thanks!

@wouterj wouterj merged commit a63b9b9 into symfony:2.3 Apr 26, 2015
wouterj added a commit that referenced this pull request Apr 26, 2015
@wouterj
minor #5200 Added missing link in "Sections" (sfdumi)
c6dc4ea 
This PR was merged into the 2.3 branch.

Discussion
----------

Added missing link in "Sections"

Commits
-------

a63b9b9 Added missing link in "Sections"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfdumi @xabbuh @wouterj