Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use https for the installer file #5218

Closed
wants to merge 3 commits into from

Conversation

javiereguiluz
Copy link
Member

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets -

@xabbuh
Copy link
Member

xabbuh commented Apr 29, 2015

@javiereguiluz We should change it in the big picture of the quick tour too.

@xabbuh
Copy link
Member

xabbuh commented Apr 29, 2015

And the PR should then be merged into the 2.3 branch.

@javiereguiluz
Copy link
Member Author

I've just updated the Quick Tour. I'm really sorry about the branch mismatch. I wanted to create the PR for 2.3 but I forgot to change the branch number.

@xabbuh
Copy link
Member

xabbuh commented Apr 29, 2015

@javiereguiluz In the installation chapter, there is one last occurrence of symfony.phar when describing the installation on Windows. And there's is also one in the best practices section about creating a new project.

@javiereguiluz
Copy link
Member Author

You are right. I've removed all the remaining symfony.phar occurrences. Thanks!

@xabbuh
Copy link
Member

xabbuh commented Apr 29, 2015

👍

@wouterj
Copy link
Member

wouterj commented May 10, 2015

I've put this on hold until we decide on symfony/symfony-installer#152

@xabbuh
Copy link
Member

xabbuh commented Oct 5, 2015

@javiereguiluz What is the status here?

@javiereguiluz
Copy link
Member Author

Closing it in favor of the new #6012

@javiereguiluz javiereguiluz deleted the use_ssl_installer branch May 24, 2018 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants