Clarify query_builder closure return type
#5228
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -165,7 +165,7 @@ If specified, this is used to query the subset of options (and their | |||
| order) that should be used for the field. The value of this option can | |||
| either be a ``QueryBuilder`` object or a Closure. If using a Closure, | |||
| it should take a single argument, which is the ``EntityRepository`` of | |||
| the entity. | |||
| the entity, and return an instance of ``QueryBuilder``. | |||
There was a problem hiding this comment.
can you please remove the serial comma before "and"?
It wasn't clear what the Closure should return when passing it in the `query_builder` option.
|
👍 |
|
Easy win! Thanks Stepan! |
weaverryan
added a commit
that referenced
this pull request
May 23, 2015
This PR was submitted for the 2.6 branch but it was merged into the 2.3 branch instead (closes #5228). Discussion ---------- Clarify `query_builder` closure return type It wasn't clear what the Closure should return when passing it in the `query_builder` option. Commits ------- fbe9ea5 Clarify `query_builder` closure return type
|
@weaverryan, thanks for merging! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It wasn't clear what the Closure should return when passing it in the
query_builderoption.