Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kernel Events Proofreading after #4901 #5297

Merged
merged 3 commits into from
May 23, 2015
Merged

Kernel Events Proofreading after #4901 #5297

merged 3 commits into from
May 23, 2015

Conversation

weaverryan
Copy link
Member

Q A
Doc fix? yes
New docs? no
Applies to 2.3+
Fixed tickets n/a

Hi guys!

This is a proofread of #4901. I removed the ticks in the titles - iirc, the ticks don't work in titles. I also fixed a few minor bugs I believe.

Thanks!

@wouterj
Copy link
Member

wouterj commented May 23, 2015

Literlas in the titles do work, but you can't reference them using :ref: or ```_(but you can reference them in the url using#kernel-request`)

@weaverryan
Copy link
Member Author

Thanks @wouterj - I re-added the literals. Look good otherwise?

When the Symfony Framework (or anything using the :class:`Symfony\\Component\\HttpKernel\\HttpKernel`)
handles a request, a few core events are dispatched so that you can add listeners
throughout the process. These are called the "kernel events". For a larger
explanation, see :doc:`/reference/http_kernel/introduction`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be /components/http_kernel/introduction afaik

@wouterj
Copy link
Member

wouterj commented May 23, 2015

apart from the typo (causing the build failure), perfect!

@xabbuh
Copy link
Member

xabbuh commented May 23, 2015

👍

@weaverryan weaverryan merged commit c7326da into 2.3 May 23, 2015
weaverryan added a commit that referenced this pull request May 23, 2015
This PR was merged into the 2.3 branch.

Discussion
----------

Kernel Events Proofreading after #4901

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.3+
| Fixed tickets | n/a

Hi guys!

This is a proofread of #4901. I removed the ticks in the titles - iirc, the ticks don't work in titles. I also fixed a few minor bugs I believe.

Thanks!

Commits
-------

c7326da another fix!
106bda9 re-adding literals
cd820d7 Proofreading after #4901
@weaverryan weaverryan deleted the internals-proofread branch May 23, 2015 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants