-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kernel Events Proofreading after #4901 #5297
Conversation
Literlas in the titles do work, but you can't reference them using |
Thanks @wouterj - I re-added the literals. Look good otherwise? |
When the Symfony Framework (or anything using the :class:`Symfony\\Component\\HttpKernel\\HttpKernel`) | ||
handles a request, a few core events are dispatched so that you can add listeners | ||
throughout the process. These are called the "kernel events". For a larger | ||
explanation, see :doc:`/reference/http_kernel/introduction`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be /components/http_kernel/introduction
afaik
apart from the typo (causing the build failure), perfect! |
👍 |
This PR was merged into the 2.3 branch. Discussion ---------- Kernel Events Proofreading after #4901 | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3+ | Fixed tickets | n/a Hi guys! This is a proofread of #4901. I removed the ticks in the titles - iirc, the ticks don't work in titles. I also fixed a few minor bugs I believe. Thanks! Commits ------- c7326da another fix! 106bda9 re-adding literals cd820d7 Proofreading after #4901
Hi guys!
This is a proofread of #4901. I removed the ticks in the titles - iirc, the ticks don't work in titles. I also fixed a few minor bugs I believe.
Thanks!