Command controller tweaks to #5062 #5299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| return $content; | ||
| return new Response($content); |
There was a problem hiding this comment.
missing use statement for response
weaverryan
force-pushed
the
command-controller-tweaks
branch
from
2457940 to
59f8c95
Compare
weaverryan
added a commit
that referenced
this pull request
May 23, 2015
This PR was merged into the 2.3 branch. Discussion ---------- Command controller tweaks to #5062 | Q | A | ------------- | --- | Doc fix? | yes #5062 | New docs? | no | Applies to | 2.3+ | Fixed tickets | #5062 Hi guys! This is a proofread and bug fix after merging #5062. Notably, I changed to use the `BufferedOutput` and returned a Response from the controller instead of the string. Please let me know if you see any errors - I was coding this right inside the docs 😇. Thanks! Commits ------- aad7277 Fixing things thanks to Wouter 59f8c95 Tweaks to the new using commands in a controller article
|
👍 Never heard of the |
| @@ -30,7 +30,8 @@ allows you to directly execute a registered command inside your controller:: | |||
| use Symfony\Bundle\FrameworkBundle\Console\Application; | |||
| use Symfony\Bundle\FrameworkBundle\Controller\Controller; | |||
| use Symfony\Component\Console\Input\ArrayInput; | |||
| use Symfony\Component\Console\Output\StreamOutput; | |||
| use Symfony\Component\Console\Output\BufferedOutput; | |||
There was a problem hiding this comment.
this is wrong. BufferedOutput does not exist in 2.3. It is a 2.4+ feature
wouterj
added a commit
that referenced
this pull request
Jun 19, 2015
… (xabbuh) This PR was merged into the 2.3 branch. Discussion ---------- [Cookbook][Console] don't use BufferedOutput on Symfony 2.3 | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | #5299 (comment) As @stof pointed out in #5299 (comment), the `StreamOutput` class is not available on Symfony 2.3. This should be reverted after merging it up to the `2.6` branch. Commits ------- 4e9e0dd don't use BufferedOutput on Symfony 2.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys!
This is a proofread and bug fix after merging #5062. Notably, I changed to use the
BufferedOutputand returned a Response from the controller instead of the string.Please let me know if you see any errors - I was coding this right inside the docs 😇.
Thanks!