Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cookbook][Controller] few tweaks to the error pages article #5309

Merged
merged 1 commit into from
May 31, 2015

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented May 24, 2015

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets

@@ -46,7 +46,7 @@ is used to render a Twig template to show the user.

.. _cookbook-error-pages-by-status-code:

This controller uses the HTTP status code, request format and the following
This controller uses the HTTP status code, the request format and the following
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if this is needed. For me (but maybe because I'm dutch), the original sentence is easier to read.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imho it reads odd the way it is now. If we omitted "the" here, we should remove it before "following logic" too. Let's see what Ryan thinks about this.

@wouterj
Copy link
Member

wouterj commented May 31, 2015

Let's merge this one. If @weaverryan disagrees with the added "the", he can always revert :)

@wouterj wouterj merged commit c7d1266 into symfony:2.3 May 31, 2015
wouterj added a commit that referenced this pull request May 31, 2015
…cle (xabbuh)

This PR was merged into the 2.3 branch.

Discussion
----------

[Cookbook][Controller] few tweaks to the error pages article

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets |

Commits
-------

c7d1266 few tweaks to the error pages article
@xabbuh xabbuh deleted the pr-5304-tweaks branch May 31, 2015 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants