Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a new entry about deprecation warnings #5329

Merged
merged 4 commits into from
May 29, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cookbook/map.rst.inc
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,7 @@
* :doc:`/cookbook/upgrade/patch_version`
* :doc:`/cookbook/upgrade/minor_version`
* :doc:`/cookbook/upgrade/major_version`
* :doc:`/cookbook/upgrade/deprecation_warnings`

* :doc:`/cookbook/validation/index`

Expand Down
74 changes: 74 additions & 0 deletions cookbook/upgrade/deprecation_warnings.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
What do these "XXX is deprecated " E_USER_DEPRECATED Warnings mean?
===================================================================

Starting in Symfony 2.7, if you use a deprecated class, function or option,
Symfony triggers an ``E_USER_DEPRECATED`` error. Internally, that looks something
like this::

trigger_error(
'The fooABC method is deprecated since version 2.4 and will be removed in 3.0.',
E_USER_DEPRECATED
);

This is great, because you can check your logs to know what needs to change
before you upgrade. In the Symfony Framework, the number of deprecated calls
shows up in the web debug toolbar. And if you install the `phpunit-bridge`_,
you can get a report of deprecated calls after running your tests.

How can I Silence the Warnings?
-------------------------------

As useful as these are, you don't want them to show up while developing and
you may also want to silence them on production to avoid filling up your
error logs.

In the Symfony Framework
~~~~~~~~~~~~~~~~~~~~~~~~

In the Symfony Framework, ``~E_USER_DEPRECATED`` is added to ``app/bootstrap.php.cache``
automatically, but you need at least version 2.3.14 or 3.0.21 of the
`SensioDistributionBundle`_. So, you may need to upgrade:

.. code-block:: bash

$ composer update sensio/distribution-bundle

Once you've updated, the ``bootstrap.php.cache`` file is rebuilt automatically.
At the top, you should see a line adding ``~E_USER_DEPRECATED``.

Outside of the Symfony Framework
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

To do that, add ``~E_USER_DEPRECATED`` to your ``error_reporting``
setting in ``php.ini``:

.. code-block:: ini

; before
error_reporting = E_ALL
; after
error_reporting = E_ALL & ~E_USER_DEPRECATED

Alternatively, you can set this directly in bootstrap of your project::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should tell them exactly in which file and which line they should put this instruction. Moreover, maybe we should also mention that calling this function will slow down the application and it's much better to just change the setting in php.ini

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with telling a specific file, but in the framework, this is taken care of for you automatically (actually, I need to add a note about that - similar to https://github.com/symfony/symfony/pull/14776/files#diff-722b43ae068b297ed9d04d3b08ec16cfR14.

And of course, outside of the framework, we don't know what files they'll have. Any other suggestion? And I'm not sure about the performance hit of calling this one function. After all, we are actually doing this in the framework.


error_reporting(error_reporting() & ~E_USER_DEPRECATED);

How can I Fix the Warnings?
---------------------------

Of course ultimately, you want to stop using the deprecated functionality.
Sometimes, this is easy: the warning might tell you exactly what to change.

But other times, the warning might be unclear: a setting somewhere might
cause a class deeper to trigger the warning. In this case, Symfony does its
best to give a clear message, but you may need to research that warning further.

And sometimes, the warning may come from a third-party library or bundle
that you're using. If that's true, there's a good chance that those deprecations
have already been updated. In that case, upgrade the library to fix them.

Once all the deprecation warnings are gone, you can upgrade with a lot
more confidence.

.. _`phpunit-bridge`: https://github.com/symfony/phpunit-bridge
.. _`SensioDistributionBundle`: https://github.com/sensiolabs/SensioDistributionBundle
1 change: 1 addition & 0 deletions cookbook/upgrade/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,4 @@ There are three types of upgrades, all needing a little different preparation:
/cookbook/upgrade/patch_version
/cookbook/upgrade/minor_version
/cookbook/upgrade/major_version
/cookbook/upgrade/deprecation_warnings