document old way of checking validity of CSRF token #5340
Conversation
snoek09
commented
May 30, 2015
snoek09
commented
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | yes |
| Applies to | all |
| Fixed tickets | Related to #4668 |
| Sometimes you want to use CSRF protection in an action where you don't want to use a | ||
| Symfony form. | ||
|
|
||
| If, for example, you're doing a DELETE action, you can use the :method:`Symfony\\Component\\Form\\Extension\\Csrf\\CsrfProvider\\CsrfProviderAdapter::isTokenValid` |
There was a problem hiding this comment.
Can you please move the method role on its own line?
|
@xabbuh done, please let me know if this needs any other changes. |
|
|
||
| If, for example, you're doing a DELETE action, you can use the | ||
| :method:`Symfony\\Component\\Form\\Extension\\Csrf\\CsrfProvider\\CsrfProviderAdapter::isTokenValid` | ||
| method to check the CSRF token:: |
There was a problem hiding this comment.
I feel that this sentence should be worded more "smoothy". Though I'm not sure how. Maybe our native speaker @weaverryan has a suggestion.
|
@snoek09 I am sorry for the delay here. Do you think we should still tackle this and reopen the PR in that case? |
|
I closed this because it is already merged into 2.6: 85dc294 |
|
Indeed, but it seems to be missing in the 2.7 version of the docs if I don't miss anything. |
|
see #5816 |
|
In that case, just re-use the text and change it where needed. |
|
@snoek09 Sorry for poking you again. I had a look at this again and I think we should actually merge this one so that we have a description in the 2.3 docs too. What do you think? |
|
As I deleted the related fork a while back and closed this PR I can't reopen this. New PR is here: #5818 |
