-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reword a paragraph about service configurations #5383
Conversation
complex offers more flexibility and is commonly used to import third-party bundle | ||
configuration. Read on to learn about both methods. | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two blank lines should be removed.
@richardudovich if I'm right, this is your first contribution to Symfony docs. Therefore, thank you for helping us improve the doc :) @xabbuh is one of the Symfony doc managers and made two comments about your pull request. As you can see, you should only remove two blank lines and add one word. After those changes, your pull request will be ready to be merged. If you have any trouble making these changes or if you have any other question/doubt about the contribution process, please ask us. We're here to help you. Thanks! |
Thanks for getting back to me. I actually wasn't sure that I was suppose to Regards On Mon, Jun 22, 2015 at 7:27 PM, Javier Eguiluz notifications@github.com
Regards *This e-mail and any attachments may contain confidential and privileged |
Thanks for your help Javier On Tue, Jun 23, 2015 at 12:00 AM, Javier Eguiluz notifications@github.com
Regards *This e-mail and any attachments may contain confidential and privileged |
Thank you for your great work @richardudovich. This reads very well to me. Please apologise if my comments where not clear enough. I sadly didn't recognize that you didn't contribute to the docs before. Our native speaker @weaverryan will have a look at the and proofread them (and hopefully just merge them :)). |
It reads very nicely to me. I've merged this into the 2.3 branch - thanks so much @richardudovich! |
…dovich) This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes #5383). Discussion ---------- Reword a paragraph about service configurations Commits ------- b63fa61 Improved wording a0f3f82 remove the two lines aa1f56b Reword a paragraph about service configurations
No description provided.