Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reword a paragraph about service configurations #5383

Closed
wants to merge 3 commits into from

Conversation

richardudovich
Copy link
Contributor

No description provided.

complex offers more flexibility and is commonly used to import third-party bundle
configuration. Read on to learn about both methods.


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two blank lines should be removed.

@javiereguiluz
Copy link
Member

@richardudovich if I'm right, this is your first contribution to Symfony docs. Therefore, thank you for helping us improve the doc :)

@xabbuh is one of the Symfony doc managers and made two comments about your pull request. As you can see, you should only remove two blank lines and add one word. After those changes, your pull request will be ready to be merged.

If you have any trouble making these changes or if you have any other question/doubt about the contribution process, please ask us. We're here to help you. Thanks!

@richardudovich
Copy link
Contributor Author

Thanks for getting back to me. I actually wasn't sure that I was suppose to
do something sorry.
In any case I have removed the two lines, but i am not sure about what word
i should add...

Regards
Richard

On Mon, Jun 22, 2015 at 7:27 PM, Javier Eguiluz notifications@github.com
wrote:

@richardudovich https://github.com/richardudovich if I'm right, this is
your first contribution to Symfony docs. Therefore, thank you for helping
us improve the doc :)

@xabbuh https://github.com/xabbuh is one of the Symfony doc managers
and made two comments about your pull request. As you can see, you should
only remove two blank lines and add one word. After those changes, your
pull request will be ready to be merged.

If you have any trouble making these changes or if you have any other
question/doubt about the contribution process, please ask us. We're here to
help you. Thanks!


Reply to this email directly or view it on GitHub
#5383 (comment)
.

Regards

*This e-mail and any attachments may contain confidential and privileged
information. If you are not the intended recipient, please notify the
sender immediately by return e-mail, delete this e-mail and destroy any
copies. Any dissemination or use of this information by a person other than
the intended recipient is unauthorized and may be illegal. *

@javiereguiluz
Copy link
Member

@richard sorry for not explaining myself properly. In the line 283 of the book/service_container.rst file you have the following:

[...] Read on to learn about both methods.

However, @xabbuh proposes you to slightly change it by the following:

[...] Read on to learn more about both methods.

@richardudovich
Copy link
Contributor Author

Thanks for your help Javier

On Tue, Jun 23, 2015 at 12:00 AM, Javier Eguiluz notifications@github.com
wrote:

@richard https://github.com/richard sorry for not explaining myself
properly. In the line 283 of the book/service_container.rst file you have
the following:

[...] Read on to learn about both methods.

However, @xabbuh https://github.com/xabbuh proposes you to slightly
change it by the following:

[...] Read on to learn more about both methods.


Reply to this email directly or view it on GitHub
#5383 (comment)
.

Regards

*This e-mail and any attachments may contain confidential and privileged
information. If you are not the intended recipient, please notify the
sender immediately by return e-mail, delete this e-mail and destroy any
copies. Any dissemination or use of this information by a person other than
the intended recipient is unauthorized and may be illegal. *

@xabbuh
Copy link
Member

xabbuh commented Jun 22, 2015

Thank you for your great work @richardudovich. This reads very well to me. Please apologise if my comments where not clear enough. I sadly didn't recognize that you didn't contribute to the docs before.

Our native speaker @weaverryan will have a look at the and proofread them (and hopefully just merge them :)).

@weaverryan
Copy link
Member

It reads very nicely to me. I've merged this into the 2.3 branch - thanks so much @richardudovich!

weaverryan added a commit that referenced this pull request Jun 22, 2015
…dovich)

This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes #5383).

Discussion
----------

Reword a paragraph about service configurations

Commits
-------

b63fa61 Improved wording
a0f3f82 remove the two lines
aa1f56b Reword a paragraph about service configurations
@weaverryan weaverryan closed this Jun 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants