Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to security.rst #5389

Closed
wants to merge 1 commit into from
Closed

Updates to security.rst #5389

wants to merge 1 commit into from

Conversation

HexTitan
Copy link
Contributor

  • Unified HTTP (it was already HTTP in some places, but not others)
  • Changed "old-school pop-up" to "old-school prompt" since it is technically a prompt, asking for input, and pop-up has negative connotations
  • Changed the wording HTTP Basic to HTTP basic auth(entication)

Thoughts?

@HexTitan
Updates to security.rst
70656f1 
- Unified HTTP (it was already HTTP in some places, but not others)
- Changed "old-school pop-up" to "old-school prompt" since it is technically a prompt, asking for input, and pop-up has negative connotations
- Changed the wording HTTP Basic to HTTP basic auth(entication)

Thoughts?
@xabbuh
Copy link
Member

xabbuh commented Jun 12, 2015

👍 looks reasonable to me

@wouterj
Copy link
Member

wouterj commented Jun 20, 2015

I agree. Thanks for your work @HexTitan! (fyi,I've merged this into the 2.3 version and will merge that up to master, so you'll see a close status while it is actually merged)

wouterj added a commit that referenced this pull request Jun 20, 2015
@wouterj
minor #5389 Updates to security.rst (HexTitan)
1306aeb 
This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes #5389).

Discussion
----------

Updates to security.rst

- Unified HTTP (it was already HTTP in some places, but not others)
- Changed "old-school pop-up" to "old-school prompt" since it is technically a prompt, asking for input, and pop-up has negative connotations
- Changed the wording HTTP Basic to HTTP basic auth(entication)

Thoughts?

Commits
-------

0448a6a Updates to security.rst
@wouterj wouterj closed this Jun 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HexTitan @xabbuh @wouterj