Quick review of the remember me article #5398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ``IS_AUTHENTICATED_ANONYMOUSLY`` | ||
| Automatically assigned to a user who is in a firewall protected part of the | ||
| site but who has not actually logged in. This is only possible if anonymous | ||
| access has been allowed. |
There was a problem hiding this comment.
Doesn't the text need to be indented?
| * ``IS_AUTHENTICATED_REMEMBERED`` - automatically assigned to a user who | ||
| was authenticated via a remember me cookie. | ||
| ``IS_AUTHENTICATED_REMEMBERED`` | ||
| Automatically assigned to a user who was authenticated via a remember me |
There was a problem hiding this comment.
As pointed previously by @xabbuh, the description should be indented if we want to display it as a definition list.
wouterj
force-pushed
the
cb/security/remember_me-review
branch
from
8158d56
to
a0d71ad
Compare
|
👍 |
xabbuh
added a commit
that referenced
this pull request
Jun 28, 2015
This PR was merged into the 2.3 branch. Discussion ---------- Quick review of the remember me article Commits ------- a0d71ad Quick review of the remember me article
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.