Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change PhpStormOpener to PhpStormProtocol #5407

Closed
wants to merge 1 commit into from
Closed

Change PhpStormOpener to PhpStormProtocol #5407

wants to merge 1 commit into from

Conversation

King2500
Copy link
Contributor

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets no

PhpStormOpener only supports Mac OS.
PhpStormProtocol supports Windows as well, so the sentence here now makes sense.

@King2500
Changed PhpStormOpener to PhpStormProtocol
39628cf 
PhpStormOpener only supports Mac OS. PhpStormProtocol supports Windows, so the sentence here now makes sense.
@javiereguiluz
Copy link
Member

👍 thanks @King2500

This looks like a quick win without any real drawback. Maybe @wouterj, who is one of the doc managers and uses Windows, can verify that PhpStormProtocol works flawlessly for him.

@xabbuh
Copy link
Member

xabbuh commented Jun 22, 2015

@wouterj tried something like this himself in 90c9ac0. So I guess this is ready to be merged (dunno what went wrong there).

Thank you for keeping the docs up-to-date @King2500!

@weaverryan
Copy link
Member

Thanks Thomas for the fix!

weaverryan added a commit that referenced this pull request Jun 28, 2015
@weaverryan
bug #5407 Change PhpStormOpener to PhpStormProtocol (King2500)
89479f6 
This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes #5407).

Discussion
----------

Change PhpStormOpener to PhpStormProtocol

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets | no

[PhpStormOpener](https://github.com/pinepain/PhpStormOpener) only supports Mac OS.
[PhpStormProtocol](https://github.com/aik099/PhpStormProtocol) supports Windows as well, so the sentence here now makes sense.

Commits
-------

c9a4001 Changed PhpStormOpener to PhpStormProtocol
@weaverryan weaverryan closed this Jun 28, 2015
@King2500 King2500 deleted the patch-1 branch July 10, 2015 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@King2500 @javiereguiluz @xabbuh @weaverryan @wouterj