Cookbook grammar and style fixes #5427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
javiereguiluz
commented
Jun 23, 2015
javiereguiluz
commented
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | 2.3+ |
| Fixed tickets | - |
| @@ -192,7 +191,7 @@ Symfony adds automatically: | |||
| .. tip:: | |||
|
|
|||
| If you followed the advice about ensuring a consistent caching | |||
| behavior, those vcl functions already exist. Just append the code | |||
| behaviour, those VCL functions already exist. Just append the code | |||
There was a problem hiding this comment.
behavior is correct (we use American English)
|
Awesome stuff! Thanks to both @frne and @javiereguiluz! |
weaverryan
added a commit
that referenced
this pull request
Jul 12, 2015
This PR was merged into the 2.3 branch. Discussion ---------- Cookbook grammar and style fixes | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3+ | Fixed tickets | - Commits ------- 1cff826 Fixed a minor typo 797aab7 Fixed minor issues a75cc15 Removed some information wrongly rebased 2af84eb Style / grammar fixes for the deployment chapter c56f912 Style / grammar fixes for the controller chapter 136230f Style / grammar fixes for the console chapter a0abc5d Removes wrong comma 974e17f Rewritten 'whether' & removed serial comma 21ebbd4 Style / grammar fixes for the configuration chapter ba6f59f Style / grammar fixes for the cache chapter 2ec4855 Style / grammar fixes for the bundles chapter bed8824 Style / grammar fixes for the assetic chapter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.