HTML5 range documentation

[harikt]

Hi,

Q	A
Doc fix?	yes
New feature?	yes
BC breaks?	no
Deprecations?	no
Fixed tickets	[#5439]
Code PR	[12607]
License	MIT

I am trying to contribute to range added for the PR symfony/symfony#12067 & symfony/symfony#11979 which fixes #5439 .

Need some help on moving for I am really new to the documentation.

The current issues I feel is whether we need to add Basic usage or is that only reference ?

I had a look at http://symfony.com/doc/current/reference/forms/types/number.html which would have been similar, but that seems it referencing to choice seems more confusing.

I have looked into other types also and almost all are some what similar.

Any input is highly appreciated and will work on in the free time. If someone is interested please do take the PR or finish it .

Thank you.

[harikt]

Hm. Anyone have idea how many spaces should be kept ?

[xabbuh]

You need one more in this and in the next line (have a look at the right most | character).

[xabbuh]

By the way, min and max are no options of the form type. You need to pass them as attr option keys.

[harikt]

may be we need attr here.

[harikt]

Hey @xabbuh ,

Thanks for all the comments. What about the examples ?

[xabbuh]

I think a simple example showing how to configure the min and max attributes should be enough (see, for example, the test cases in the code pull request: https://github.com/symfony/symfony/pull/12067/files#diff-e11656489f1e01413320bd5edff0f0c7R1350).

[harikt]

Hey @xabbuh ,

May be I didn't explained better regarding what I was referencing to.

Basically if you check the markdown of http://symfony.com/doc/current/reference/forms/types/number.html ( https://raw.githubusercontent.com/harikt/symfony-docs/range/reference/forms/types/number.rst ) , you can see the number was not having the correct examples. It refers to hidden, choice fields etc for data, empty_data etc .

I will make the changes and get back.

Thank you.

[snoek09]

Please add a code-block directive before the example code:

.. code-block:: php

    $builder->add('name', 'range', array(

[harikt]

sure. Thanks.

[snoek09]

The new range documentation isn't included anywhere yet.
Please add it to the list in /reference/forms/types.rst

I found these small issues by testing the documentation first on my local machine:
http://symfony.com/doc/current/contributing/documentation/format.html#testing-documentation

[harikt]

@xabbuh @snoek09 thank you guys for your time and review.

Have updated the changes.

Thank you.

[xabbuh]

This description should be moved before the mapped option's description.

[xabbuh]

Very great @harikt. I left you one minor comment. After that I think this looks ready to be merged.

[harikt]

@xabbuh done 👍 .

Thank you.

[xabbuh]

👍

[weaverryan]

@harikt! This is wonderful! I have no changes - and now I can also close the related issue :). Thanks!

[harikt]

cool. Thank you all.