Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo in components/translation/instruction.rst #5474

Closed
wants to merge 1 commit into from
Closed

typo in components/translation/instruction.rst #5474

wants to merge 1 commit into from

Conversation

beesofts
Copy link
Contributor

@beesofts beesofts commented Jul 2, 2015

$translator->setFallbackLocale() should be $translator->setFallbackLocales()

$translator->setFallbackLocale() should be $translator->setFallbackLocales()
xabbuh added a commit that referenced this pull request Jul 2, 2015
This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes #5474).

Discussion
----------

typo in components/translation/instruction.rst

$translator->setFallbackLocale() should be $translator->setFallbackLocales()

Commits
-------

fda8ff5 typo in components/translation/instruction.rst
@xabbuh
Copy link
Member

xabbuh commented Jul 2, 2015

Technically, setFallbackLocale() does exist. But, I agree that we should not advocate to use deprecated methods. I have taken your changes and applied them on the 2.3 branch as this is the version the method got first deprecated. That's why you see the PR status as closed while the changes are actually merged into the repository. Thank you for this fix @beesofts!

@xabbuh xabbuh closed this Jul 2, 2015
@beesofts beesofts deleted the patch-2 branch July 15, 2015 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants