Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #5487 #5488

Closed
wants to merge 2 commits into from
Closed

fix #5487 #5488

wants to merge 2 commits into from

Conversation

emillosanti
Copy link
Contributor

No description provided.

@emillosanti
resolve symfony#5487
5c1b5e0 
[create_framework] phpunit test error symfony#5487

Call to a member function fromRequest() on a non-object in .../src/Simplex/Framework.php on line 29
@emillosanti
Merge pull request #1 from emillosanti/emillosanti-patch-1
4a5c538 
resolve symfony#5487
@xabbuh xabbuh mentioned this pull request Jul 7, 2015
Closed
xabbuh added a commit that referenced this pull request Jul 7, 2015
@xabbuh
bug #5488 fix #5487 (emillosanti)
5624ed7 
This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes #5488).

Discussion
----------

fix #5487

Commits
-------

68c7364 fix #5487
@xabbuh
Copy link
Member

xabbuh commented Jul 7, 2015

Thank you @emillosanti. That's an easy win. I merged your changes into the 2.3 branch. That's why the pull request is shown as closed.

@xabbuh xabbuh closed this Jul 7, 2015
@wouterj wouterj mentioned this pull request Dec 19, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emillosanti @xabbuh