Misc. improvements in the Console component introduction #5545
Conversation
javiereguiluz
commented
Jul 21, 2015
javiereguiluz
commented
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | all |
| Fixed tickets | - |
| @@ -140,6 +140,9 @@ output. For example:: | |||
| // white text on a red background | |||
| $output->writeln('<error>foo</error>'); | |||
|
|
|||
| The closing tag can be replaced by just ``</>``. This makes the component to | |||
| stop applying any style defined by the immediately previous open tag. | |||
There was a problem hiding this comment.
I would reword this a bit:
The closing tag can be replaced by
</>which simply closes the last opened tag.
There was a problem hiding this comment.
I don't like my original text ... but I don't like either the new proposal. My fear is that reader would say: obviously the close tag closes the opened tag!!! In this case, the close tag is not about closing tags but about "neutralizing" the effects applied in the previously opened tag. I don't know if I explained myself because it's not easy to explain what I want to say :(
There was a problem hiding this comment.
Maybe then something like
The closing tag can be replaced by
</>which revokes all formatting options established by the last opened tag.
There was a problem hiding this comment.
I like it. I've just updated it. Thanks!
|
👍 |
| And available options are: ``bold``, ``underscore``, ``blink``, ``reverse`` | ||
| (enables the "reverse video" mode where the background and foreground colors | ||
| are swapped) and ``conceal`` (the text will be hidden; commonly used to ask | ||
| the user to type sensitive information). |
There was a problem hiding this comment.
I don't think this is a very good explanation of conceal. It just makes the foreground color transparent. The text is still there (and visible when copy/pasting the terminal text). Besides that, the "input box" of questions can't be styled.
There was a problem hiding this comment.
I've reworded the explanation. Thanks.
|
👍 |
|
Thanks Javier. |
…(javiereguiluz) This PR was squashed before being merged into the 2.3 branch (closes #5545). Discussion ---------- Misc. improvements in the Console component introduction | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | - Commits ------- 40eb0bd Misc. improvements in the Console component introduction
