Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docbot] Reviewed some component chapters #5550

Merged
merged 4 commits into from
Jul 28, 2015
Merged

[docbot] Reviewed some component chapters #5550

merged 4 commits into from
Jul 28, 2015

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Jul 22, 2015

No description provided.

javiereguiluz
javiereguiluz reviewed Jul 22, 2015
View reviewed changes
components/config/caching.rst
@@ -1,26 +1,27 @@
.. index::
single: Config; Caching based on resources

Caching Based on Resources
Caching based on Resources
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the twisted logic behind title casing, but are we sure about this change?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah looks odd to me too (isn't "based" derived from "to base (sth. on sth.)"?)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked odd to me at first, looks ok to me now - and I verified that lowercase makes sense from one quick source. Mostly, I don't care either way :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really get the feeling that we should think again about our capitalisation rule. :)

@javiereguiluz
Copy link
Member

👍 thanks for taking care of these boring but useful changes.

@stof
Copy link
Member

stof commented Jul 22, 2015

@wouterj is docbot ready to be run as a CI service or not yet ?

OskarStark
OskarStark reviewed Jul 23, 2015
View reviewed changes
components/class_loader/class_loader.rst
:method:`Symfony\\Component\\ClassLoader\\ClassLoader::addPrefixes` methods to
register your classes::
Use the :method:`Symfony\\Component\\ClassLoader\\ClassLoader::addPrefix`
or :method:`Symfony\\Component\\ClassLoader\\ClassLoader::addPrefixes` methods
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think methods should be method @wouterj

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 (even though it's unrelated to the PR)

@weaverryan
Copy link
Member

👍 from me after the few comments

@wouterj wouterj merged commit 0d28306 into symfony:2.3 Jul 28, 2015
wouterj added a commit that referenced this pull request Jul 28, 2015
@wouterj
minor #5550 [docbot] Reviewed some component chapters (WouterJ)
1ce8fb1 
This PR was merged into the 2.3 branch.

Discussion
----------

[docbot] Reviewed some component chapters

Commits
-------

0d28306 Fixed issues discovered by the human reviewers
b85837f Reviewed EventDispatcher docs
a045995 Fix BOM characters
01cdbf5 Reviewed some component chapters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wouterj @javiereguiluz @stof @weaverryan @OskarStark @xabbuh