-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added result yaml and xml from example code #5555
Conversation
Shouldn't we also add an XML example? (we can help with creating the example if you need help) |
Will do after holiday Greetings from turkey ;) |
done @wouterj btw. why is |
|
||
.. code-block:: xml | ||
|
||
<config> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be <database>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any idea? @javiereguiluz @xabbuh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The root element is replaced by <config>
when using configuration in a DI extension. However, this is about using config standalone, in which case the root element is just used (so <database>
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shall i add another key on top so he result uses database and the remove the config node?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, we are talking about config usage standalone and not inside a DI extension in this article. so you should just replace the <config>
element with <database>
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah ok, sorry i missunderstood you
done @wouterj |
if i could do anything else, please let me know. |
Is there a reason not to wrap the two code blocks in a configuration block? |
i did this because of the different highlighting. |
What do you mean with different highlighting? I mean we should not put both examples in one .. configuration-block::
.. code-block:: yaml
# ...
.. code-block:: xml
<!-- ... --> |
oh nice, will have a look at it 👍 |
updated @xabbuh |
👍 |
1 similar comment
👍 |
Thank you Oskar for your work on this one! |
👍 thank you for the review time ;-) |
No description provided.