Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added result yaml and xml from example code #5555

Closed
wants to merge 2 commits into from

Conversation

OskarStark
Copy link
Contributor

No description provided.

@wouterj
Copy link
Member

wouterj commented Jul 28, 2015

Shouldn't we also add an XML example? (we can help with creating the example if you need help)

@OskarStark
Copy link
Contributor Author

Will do after holiday

Greetings from turkey ;)

@OskarStark
Copy link
Contributor Author

done @wouterj

btw. why is database-key not used in the xml??


.. code-block:: xml

<config>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be <database>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes should, but i executed this code from the doc and this was the result.

bildschirmfoto 2015-08-10 um 18 24 29

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The root element is replaced by <config> when using configuration in a DI extension. However, this is about using config standalone, in which case the root element is just used (so <database>).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall i add another key on top so he result uses database and the remove the config node?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, we are talking about config usage standalone and not inside a DI extension in this article. so you should just replace the <config> element with <database>.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok, sorry i missunderstood you

@OskarStark OskarStark changed the title added result yml from example code added result yml and xml from example code Aug 11, 2015
@OskarStark OskarStark changed the title added result yml and xml from example code added result yaml and xml from example code Aug 11, 2015
@OskarStark
Copy link
Contributor Author

done @wouterj

@OskarStark
Copy link
Contributor Author

if i could do anything else, please let me know.

@xabbuh
Copy link
Member

xabbuh commented Aug 17, 2015

Is there a reason not to wrap the two code blocks in a configuration block?

@OskarStark
Copy link
Contributor Author

i did this because of the different highlighting.

@xabbuh
Copy link
Member

xabbuh commented Aug 18, 2015

What do you mean with different highlighting? I mean we should not put both examples in one code-block directive, but we can wrap both code blocks in one configuration block like this:

.. configuration-block::

    .. code-block:: yaml

        # ...

    .. code-block:: xml

        <!-- ... -->

@OskarStark
Copy link
Contributor Author

oh nice, will have a look at it 👍

@OskarStark
Copy link
Contributor Author

updated @xabbuh

@xabbuh
Copy link
Member

xabbuh commented Aug 18, 2015

👍

1 similar comment
@wouterj
Copy link
Member

wouterj commented Sep 5, 2015

👍

@wouterj
Copy link
Member

wouterj commented Sep 5, 2015

Thank you Oskar for your work on this one!

wouterj added a commit that referenced this pull request Sep 5, 2015
This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes #5555).

Discussion
----------

added result yaml and xml from example code

Commits
-------

a1ef572 added result yaml and xml from example code
@wouterj wouterj closed this Sep 5, 2015
@OskarStark
Copy link
Contributor Author

👍 thank you for the review time ;-)

@OskarStark OskarStark deleted the patch-5 branch September 7, 2015 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants