Upgrade Platform.sh configuration snippet. #5633
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| toolstack: "php:symfony" | ||
|
|
||
| # The type of the application to build. | ||
| type: php:5.4 |
There was a problem hiding this comment.
Giving a version number here does work? Just asking as it is not explained in the docs.
There was a problem hiding this comment.
if it does, I would vote to use a newer version if possible (although no PHP is used by this project, it's quite nice to show a good practice not using versions that reached eol)
|
This is documented here: https://docs.platform.sh/user_guide/reference/platform-app-yaml.html#type-and-build. Platform.sh can currently build 3 of the following PHP versions: 5.4, 5.5, 5.6. Thanks for the review guys! |
|
👍 |
1 similar comment
|
👍 |
|
Thank you Augustin. |
xabbuh
added a commit
that referenced
this pull request
Aug 19, 2015
This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes #5633). Discussion ---------- Upgrade Platform.sh configuration snippet. Following a recent Platform.sh upgrade: https://docs.platform.sh/user_guide/reference/upgrade/index.html Commits ------- df0afdd Upgrade Platform.sh configuration snippet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following a recent Platform.sh upgrade: https://docs.platform.sh/user_guide/reference/upgrade/index.html