Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better explanation of implicit exception response status code #5669

Closed
wants to merge 2 commits into from
Closed

Better explanation of implicit exception response status code #5669

wants to merge 2 commits into from

Conversation

hvt
Copy link
Contributor

@hvt hvt commented Sep 2, 2015

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets none

@hvt hvt mentioned this pull request Sep 2, 2015
Closed
javiereguiluz
javiereguiluz reviewed Sep 2, 2015
View reviewed changes
reference/events.rst
'Error',
404 // ignored,
array('X-Status-Code' => 200)
404 // this status code will be ignored,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the comma should go after the 404 number to avoid syntax errors (previously was also wrong of course)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha, good catch :]

@javiereguiluz
Copy link
Member

👍

@xabbuh
Copy link
Member

xabbuh commented Sep 5, 2015

👍

@wouterj
Copy link
Member

wouterj commented Sep 5, 2015

Thanks Harm! This is very easy to understand now.

wouterj added a commit that referenced this pull request Sep 5, 2015
@wouterj
minor #5669 Better explanation of implicit exception response status …
d64e993 
…code (hvt)

This PR was squashed before being merged into the 2.3 branch (closes #5669).

Discussion
----------

Better explanation of implicit exception response status code

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets | none

Commits
-------

54f77d8 Better explanation of implicit exception response status code
@wouterj wouterj closed this Sep 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hvt @javiereguiluz @xabbuh @wouterj