-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the demo-warning. #5683
Conversation
To me, the way it is shown is totally fine. 👍 |
<a href="http://symfony.com/doc/current/{{ pagename }}">Visit on symfony.com</a>.</p> | ||
<h4>Pull request build</h4> | ||
<p>Each pull request of the Symfony Documentation is automatically deployed and hosted on <a href="https://platform.sh">Platform.sh</a>.<br> | ||
Visit the page on <a href="http://symfony.com/doc/current/{{ pagename }}">symfony.com</a>.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should link to the HTTPS docs here.
thanks @xabbuh for your review. |
👍 |
@weaverryan @wouterj @javiereguiluz Any opinion on this one? @GuGuss I would like to a 👍 from another docs team member before merging here. |
I like the reworded message and I think it's fair to add the link to platform.sh. My only concern is about the "Visit the page on symfony.com" message. I'm not sure if its intention is clear enough and by the way, it won't work when the page is new (which I know it's not a very frequent scenario). Anyway, my concern can be also applied to the original message, so I'm 👍 about merging these changes. |
I agree that we can handle this in a different pull request if we feel the need to do so. |
Thank you Augustin. |
@xabbuh @javiereguiluz you guys rock as reviewers! I wish there were more community projects like this one! |
@javiereguiluz I added the "view this page on symfony.com" for 2 reasons: (a) People on the demo docs that just wanted to read the doc page can quickly navigate to the doc page and (b) I've used it a couple of times already to quickly create a visual diff (e.g. when someone fixes some syntax and I want to quicly check if it really did fix anything) |
@wouterj I agree and like this feature :) My concern is about the text of the link. The original was "Visit on symfony.com" and the new one is "Visit the page on symfony.com" I think that the text you included in your comment is much better: "View this page on symfony.com" |
I've just updated the language |
We need a link to Platform.sh and a very small explanation of it.