Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added caution to call createView after handleRequest #5708

Merged
merged 1 commit into from
Oct 3, 2015
Merged

Added caution to call createView after handleRequest #5708

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions book/forms.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,13 +232,21 @@ controller::
$form->handleRequest($request);

if ($form->isValid()) {
// perform some action, such as saving the task to the database
// ... perform some action, such as saving the task to the database

return $this->redirect($this->generateUrl('task_success'));
}

// ...
return $this->render('default/new.html.twig', array(
'form' => $form->createView(),
));
}

.. caution::

Be aware that the ``createView()`` method should be called *after* ``handleRequest``
is called. Otherwise, changes done in the ``*_SUBMIT`` events aren't applied to the
view (like validation errors).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

view (like validation errors) -> i.e. validation errors etc. ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about "(like, for example, validation errors)"?


.. versionadded:: 2.3
The :method:`Symfony\\Component\\Form\\FormInterface::handleRequest` method
Expand Down