Minor tweaks for the registration form article #5794
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
javiereguiluz
commented
Oct 16, 2015
javiereguiluz
commented
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | all |
| Fixed tickets | - |
|
👍 |
| @@ -19,12 +19,12 @@ first start with :doc:`/cookbook/security/entity_provider`. | |||
|
|
|||
| Your ``User`` entity will probably at least have the following fields: | |||
|
|
|||
| ``username`` | |||
| * ``username`` | |||
There was a problem hiding this comment.
can you please explain why you did this? The previous definition list syntax seems better than the unordered list syntax.
There was a problem hiding this comment.
If you browse this page (http://symfony.com/doc/current/cookbook/doctrine/registration_form.html) you'll understand why I did this :)
There was a problem hiding this comment.
Isn't it better to change the other 2 to be a definition list?
There was a problem hiding this comment.
Yes. Done. Thanks.
|
👍 for definition list instead of an unordered list |
|
👍 |
1 similar comment
|
👍 |
|
Thanks Javier. |
xabbuh
added a commit
that referenced
this pull request
Oct 18, 2015
…iluz) This PR was squashed before being merged into the 2.3 branch (closes #5794). Discussion ---------- Minor tweaks for the registration form article | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | - Commits ------- 91cb3a0 Minor tweaks for the registration form article
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.