Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make file path consitent with other articles #5799

Closed
wants to merge 1 commit into from

Conversation

OskarStark
Copy link
Contributor

added src/ to the beginning of the file path

Greetings from Symfony Live Berlin 2015 - Hack Day 😄

@wouterj
Copy link
Member

wouterj commented Oct 17, 2015

👍

@@ -354,7 +354,7 @@ object.

.. code-block:: php-annotations

// AppBundle/Entity/Task.php
// src/AppBundle/Entity/Task.php
use Symfony\Component\Validator\Constraints as Assert;

class Task
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that you are at it: Could you please also add the namespace?

xabbuh added a commit that referenced this pull request Oct 18, 2015
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #5799).

Discussion
----------

make file path consitent with other articles

added ``src/`` to the beginning of the file path

Greetings from Symfony Live Berlin 2015 - Hack Day 😄

Commits
-------

1615efd make file path consitent with other articles
xabbuh added a commit that referenced this pull request Oct 18, 2015
@xabbuh
Copy link
Member

xabbuh commented Oct 18, 2015

Thanks Oskar, I have merged the fix into the 2.3 branch and added the namespace in f9ac618.

@xabbuh xabbuh closed this Oct 18, 2015
@OskarStark OskarStark deleted the file-path branch June 17, 2019 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants