use composer command instead of editing json file #5829
Conversation
|
Nice! 👍 I'd tweak it a bit and I'd remove the version number to leave it as follows: |
|
I agree. There's little risk a compatibility package releases a new major version containing BC breaks. Though if we wanted to keep a version, I would use |
|
if the version is not necessary i am 👍 but i remembered this: sonata-project/SonataAdminBundle#2649 (diff) |
|
@OskarStark thanks for the info. I agree with @xabbuh's comments. |
|
so everything is fine or shall i change something? |
|
I'd use: |
|
fine for me, will change that |
|
Done, branch |
| "ircmaxell/password-compat": "~1.0.3" | ||
| } | ||
| } | ||
| composer require ircmaxell/password-compat:~1.0 |
There was a problem hiding this comment.
If I am not mistaken we always prefix shell commands with $.
There was a problem hiding this comment.
you are right, i fixed it
|
I actually do not like the version (note that the comment of me you linked was talking about a root package install, otherwise we often omit the version number). However, if we want to use the version, we should change it to this to have Windows compability: $ composer require ircmaxell/password-compat "~1.0" |
|
@OskarStark can you please take a look at my comment and update this PR or comment? |
|
Will change that |
OskarStark
force-pushed
the
patch-9
branch
2 times, most recently
from
eebc487 to
e171e68
Compare
|
done! fine? |
…tark) This PR was merged into the 2.3 branch. Discussion ---------- use composer command instead of editing json file Commits ------- a862a8c use composer command instead of editing json file
|
Yes, perfect. Thanks! 🎄 |
|
Thank you |
|
@OskarStark @wouterj It has been merged without the word |
|
Hmm, yes indeed. That has slipped through, can you please submit a PR to fix it? |
|
done @wouterj and good catch @JHGitty, thank you 👍 |
No description provided.