Updated csrf_in_login_form.rst to include new labels #5942
Conversation
…n_generator Updated CSRF documentation to rename intention and csrf_provider. They were renamed in SF 3.0 to csrf_token_id and csrf_token_generator.
|
the csrf_provider change is also done in 2.8 (deprecating the old one). Otherwise, it would not have matched our upgrade policy |
|
and the change should be done in the 2.8 branch actually, to avoid using the deprecated names |
| @@ -33,7 +37,9 @@ provider available in the Security component: | |||
| # ... | |||
| form_login: | |||
| # ... | |||
| csrf_provider: security.csrf.token_manager | |||
| # Use csrf_provider in SF <2.8 | |||
There was a problem hiding this comment.
no need for such comment. this is why we have a versionned doc. Just put a versionadded section saying that the name has changed in 2.8
|
We can add something like the following below the configuration block: .. versionadded:: 2.8
The ``intention`` and ``csrf_token_generator`` options were introduced
in Symfony 2.8. Prior, you had to use the ``csrf_token_id`` and ``csrf_provider``
options.@Raistlfiren You can make the changes here. We should be able to safely backport the PR to the |
|
Need a new commit to rebuild this PR on Platform.sh. |
|
The SecurityBundle configuration reference should also be updated: http://symfony.com/doc/2.8/reference/configuration/security.html |
|
I was a little bit confused while upgrading to Symfony 3.0. |
|
We're getting more and more reports from users suffering this issue while upgrading to 3.0. Let me know if we can help you in any way to get this merged soon. Thanks! |
|
Thank you @Raistlfiren for starting this. I have taken your changes and finished them in #6152. That's why I close here. However, you will still get the full credit for your contribution as I kept all your commits. |
…lfiren, Aaron Valandra, xabbuh) This PR was merged into the 2.7 branch. Discussion ---------- csrf_token_generator and csrf_token_id documentation | Q | A | ------------- | --- | Doc fix? | no | New docs? | yes (symfony/symfony#6554, symfony/symfony#9587) | Applies to | 2.4+ | Fixed tickets | #3059, #5942 Commits ------- 304d7a5 finish csrf_token_generator and csrf_token_id docs 3ceb61c Improper markdown for versionadded. 91b5e2e Updated documentation as requested by @stof and @xabbuh 0044aa2 Updated csrf_in_login_form.rst to include csrf_token_id and csrf_token_generator
Updated CSRF documentation to rename intention and csrf_provider. They were renamed in SF 3.0 to csrf_token_id and csrf_token_generator. In SF 2.8 intention is depreciated and in SF 2.8 csrf_provider is still being used.