Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention commiting only bower.json #6043

Merged
merged 2 commits into from
Dec 31, 2015
Merged

Mention commiting only bower.json #6043

merged 2 commits into from
Dec 31, 2015

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Dec 18, 2015

Replaces #5778

Q A
Doc fix? no
New docs? yes
Applies to all
Fixed tickets -

The section is called "Should I Git Ignore or Commit Bower Assets?", but we cover only the commit way and not the git ignore way, giving users a bit biased information. We should at least mention that people can also commit bower.json.

Thanks to @KriKe for providing the original patch!

If you don't care too much about having *exact* the same versions, you can only
commit the ``bower.json`` file. Running ``bower install`` will give you the
latest versions within the specified version range of each package in
``boewr.json``. Using strict version constraints (e.g. ``1.10.*``) is often
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small typo there

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks!

@xabbuh
Copy link
Member

xabbuh commented Dec 20, 2015

👍

@xabbuh
Copy link
Member

xabbuh commented Dec 31, 2015

Thank you @KriKe.

@xabbuh xabbuh merged commit d701e3d into symfony:2.3 Dec 31, 2015
xabbuh added a commit that referenced this pull request Dec 31, 2015
This PR was merged into the 2.3 branch.

Discussion
----------

Mention commiting only bower.json

Replaces #5778

| Q | A
| --- | ---
| Doc fix? | no
| New docs? | yes
| Applies to | all
| Fixed tickets | -

The section is called "Should I Git Ignore or Commit Bower Assets?", but we cover only the commit way and not the git ignore way, giving users a bit biased information. We should at least mention that people can also commit bower.json.

Thanks to @KriKe for providing the original patch!

Commits
-------

d701e3d Rewrite section about bower.json
1a98bca Add mention for Bower.json
@wouterj wouterj deleted the krike-2.8 branch December 31, 2015 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants