-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a note about needing to install proxy-manager #6087
Conversation
@@ -103,6 +103,9 @@ your lazy loaded services are working. | |||
If you don't install the `ProxyManager bridge`_, the container will | |||
just skip over the ``lazy`` flag and simply instantiate the service | |||
as it would normally do. | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would use a separate not block and maybe add a url to the repo
@mcfedr thanks for sending this proposal. You are obviously right, but do you think we really need this addition to the docs? In this same article, in the Installation section, we already explained that you need to install |
@javiereguiluz Interesting, I for one hadn't even looked on that page, I think as the note about adding I wouldnt look at Installation page for dependency injection as its installed in full-stack Symfony by default. |
Looking again, maybe I was just being a bit short sighted... |
OK. What if we reword a bit the current phrase instead of adding a new one. Example:
|
Sounds good |
When using symfony/symfony it 'provides' `symfony/proxy-manager-bridge` but it doesn't install `ocramius/proxy-manager`. This means that when you install the bridge you still don't get the proxy-manager and lazy services are not lazy.
This would be really helpful! |
just skip over the ``lazy`` flag and simply instantiate the service | ||
as it would normally do. | ||
If you don't install the `ProxyManager bridge`_ and the | ||
`ocramius/proxy-manager`_, the container will just skip over the ``lazy`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add the word "packages" before the comma.
👍 |
Thank you for this addition Fred! I'm sorry for the long delay, but this is now merged into the documentation. |
This PR was submitted for the 3.0 branch but it was merged into the 2.3 branch instead (closes #6087). Discussion ---------- Add a note about needing to install proxy-manager When using symfony/symfony it 'provides' `symfony/proxy-manager-bridge` but it doesn't install `ocramius/proxy-manager`. This means that when you install the bridge you still don't get the proxy-manager and lazy services are not lazy. Commits ------- 37fb204 Add a note about needing to install proxy-manager
When using symfony/symfony it 'provides'
symfony/proxy-manager-bridge
but it doesn't installocramius/proxy-manager
.This means that when you install the bridge you still don't get the proxy-manager and lazy services are not lazy.