Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a note about needing to install proxy-manager #6087

Closed
wants to merge 1 commit into from

Conversation

mcfedr
Copy link
Contributor

@mcfedr mcfedr commented Dec 29, 2015

When using symfony/symfony it 'provides' symfony/proxy-manager-bridge but it doesn't install ocramius/proxy-manager.
This means that when you install the bridge you still don't get the proxy-manager and lazy services are not lazy.

@@ -103,6 +103,9 @@ your lazy loaded services are working.
If you don't install the `ProxyManager bridge`_, the container will
just skip over the ``lazy`` flag and simply instantiate the service
as it would normally do.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would use a separate not block and maybe add a url to the repo

@javiereguiluz
Copy link
Member

@mcfedr thanks for sending this proposal. You are obviously right, but do you think we really need this addition to the docs? In this same article, in the Installation section, we already explained that you need to install ocramius/proxy-manager, right?

lazy_services_installation

@mcfedr
Copy link
Contributor Author

mcfedr commented Jan 11, 2016

@javiereguiluz Interesting, I for one hadn't even looked on that page, I think as the note about adding symfony/proxy-manager-bridge is repeated here, its probably worth repeating ocramius/proxy-manager. It took me way to long, searching though the code of proxy-manager-bridge and my vendor folder to work out why my lazy services were not lazy.

I wouldnt look at Installation page for dependency injection as its installed in full-stack Symfony by default.

@mcfedr
Copy link
Contributor Author

mcfedr commented Jan 11, 2016

Looking again, maybe I was just being a bit short sighted...

@javiereguiluz
Copy link
Member

OK. What if we reword a bit the current phrase instead of adding a new one. Example:

If you don't install the `ProxyManager bridge`_ and the `ocramius/proxy-manager`_,
the container will just skip over the ``lazy`` flag and simply instantiate the service
as it would normally do.

[...]

.. _`ocramius/proxy-manager`: https://github.com/Ocramius/ProxyManager

@mcfedr
Copy link
Contributor Author

mcfedr commented Jan 11, 2016

Sounds good

When using symfony/symfony it 'provides' `symfony/proxy-manager-bridge` but it doesn't install `ocramius/proxy-manager`.
This means that when you install the bridge you still don't get the proxy-manager and lazy services are not lazy.
@TomasVotruba
Copy link

This would be really helpful!

just skip over the ``lazy`` flag and simply instantiate the service
as it would normally do.
If you don't install the `ProxyManager bridge`_ and the
`ocramius/proxy-manager`_, the container will just skip over the ``lazy``
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add the word "packages" before the comma.

@xabbuh
Copy link
Member

xabbuh commented Mar 7, 2016

👍

@wouterj
Copy link
Member

wouterj commented May 21, 2016

Thank you for this addition Fred! I'm sorry for the long delay, but this is now merged into the documentation.

wouterj added a commit that referenced this pull request May 21, 2016
This PR was submitted for the 3.0 branch but it was merged into the 2.3 branch instead (closes #6087).

Discussion
----------

Add a note about needing to install proxy-manager

When using symfony/symfony it 'provides' `symfony/proxy-manager-bridge` but it doesn't install `ocramius/proxy-manager`.
This means that when you install the bridge you still don't get the proxy-manager and lazy services are not lazy.

Commits
-------

37fb204 Add a note about needing to install proxy-manager
@wouterj wouterj closed this May 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants