Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an example for info() method #6091

Merged
merged 3 commits into from
Jan 7, 2016
Merged

Conversation

javiereguiluz
Copy link
Member

Q A
Doc fix? no
New docs? yes
Applies to all
Fixed tickets -

This PR just rebases the work made by @OskarStark in #5632.

->children()
->inetegerNode('entries_per_page')
->info('This value is only used for the search results page.')
->devaultValue(25)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deFaultValue

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thanks.


$rootNode
->children()
->inetegerNode('entries_per_page')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

integerNode has a typo 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This clearly proves that I didn't review anything when creating this PR. It's fixed now. Thanks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@xabbuh
Copy link
Member

xabbuh commented Dec 31, 2015

👍

@OskarStark
Copy link
Contributor

This should be merged now IMO

wouterj added a commit that referenced this pull request Jan 7, 2016
This PR was merged into the 2.3 branch.

Discussion
----------

Added an example for info() method

| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | yes
| Applies to    | all
| Fixed tickets | -

This PR just rebases the work made by @OskarStark in #5632.

Commits
-------

f966c0f Fixed another typo
26a8d1f Fixed a typo
9922273 Added an example for info() method
@wouterj wouterj merged commit f966c0f into symfony:2.3 Jan 7, 2016
@wouterj
Copy link
Member

wouterj commented Jan 7, 2016

Thanks @javiereguiluz and @OskarStark! I've merged this PR now.

Fyi, I've removed the XML example in the 2.3 docs, as the Xml dumper was introduced in Symfony 2.4. I've made sure it's there in the 2.7+ docs.

@OskarStark
Copy link
Contributor

👍

@javiereguiluz javiereguiluz deleted the fix_5632 branch May 24, 2018 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants