-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added an example for info() method #6091
Conversation
->children() | ||
->inetegerNode('entries_per_page') | ||
->info('This value is only used for the search results page.') | ||
->devaultValue(25) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deFaultValue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. Thanks.
|
||
$rootNode | ||
->children() | ||
->inetegerNode('entries_per_page') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
integerNode has a typo 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This clearly proves that I didn't review anything when creating this PR. It's fixed now. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
👍 |
This should be merged now IMO |
This PR was merged into the 2.3 branch. Discussion ---------- Added an example for info() method | Q | A | ------------- | --- | Doc fix? | no | New docs? | yes | Applies to | all | Fixed tickets | - This PR just rebases the work made by @OskarStark in #5632. Commits ------- f966c0f Fixed another typo 26a8d1f Fixed a typo 9922273 Added an example for info() method
Thanks @javiereguiluz and @OskarStark! I've merged this PR now. Fyi, I've removed the XML example in the 2.3 docs, as the Xml dumper was introduced in Symfony 2.4. I've made sure it's there in the 2.7+ docs. |
👍 |
This PR just rebases the work made by @OskarStark in #5632.