Use hash_equals instead of StringUtils::equals #6231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -5,6 +5,11 @@ The Symfony Security component comes with a collection of nice utilities | |||
| related to security. These utilities are used by Symfony, but you should | |||
| also use them if you want to solve the problem they address. | |||
|
|
|||
| .. note:: | |||
|
|
|||
| All functions described in this article were introduced in PHP 7. For older | |||
There was a problem hiding this comment.
hash_equals() was introduced in PHP 5.6.
wouterj
force-pushed
the
secure_tools-hash-equas
branch
from
ae24142 to
9f7f1dd
Compare
|
Thank you Wouter. |
xabbuh
added a commit
that referenced
this pull request
Feb 7, 2016
This PR was merged into the 2.3 branch. Discussion ---------- Use hash_equals instead of StringUtils::equals | Q | A | --- | --- | doc fix? | yes | new docs? | yes | applies to | 2.3+ | Fixed tickets | - We've merged #6104 in the 2.3 branch, so I think we should use the `hash_equals` function the 2.3 docs as well. Now, this article isn't related to the Security component at all and it might be a good start for the Polyfill component. Commits ------- 9f7f1dd Use hash_equals instead of StringUtils::equals
|
|
||
| The functions described in this article were introduced in PHP 5.6 or 7. | ||
| For older PHP versions, a polyfill is provided by the | ||
| `Symfony Polyfill Component`_. |
There was a problem hiding this comment.
We need a component section for the polyfills to which we can link instead where explain that you should rather install the polyfill packages you need instead of the big meta package imo (see #6052).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've merged #6104 in the 2.3 branch, so I think we should use the
hash_equalsfunction the 2.3 docs as well. Now, this article isn't related to the Security component at all and it might be a good start for the Polyfill component.