[Form] fix 'data_class' option in EntityType #6267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -21,6 +20,7 @@ objects from the database. | |||
| +-------------+------------------------------------------------------------------+ | |||
| | Overridden | - `choice_list`_ | | |||
| | options | - `choices`_ | | |||
| | | - `data_class`_ | | |||
There was a problem hiding this comment.
We need to remove two spaces before the last pipe character.
|
The first |
HeahDude
force-pushed
the
reorder-entity_type-options
branch
from
b67b0f6 to
220b5e9
Compare
|
@xabbuh thank you, fixed ! |
| em | ||
| ~~ | ||
|
|
||
| **type**: ``string`` **default**: the default entity manager | ||
| **type**: ``string`` **default**: the default entity manager class |
There was a problem hiding this comment.
Well, this option can be a string. But then it is the manager name not the class name. Additionally, you can also pass . ObjectManager instances here.
There was a problem hiding this comment.
@xabbuh, thanks, now understood and fixed !
HeahDude
force-pushed
the
reorder-entity_type-options
branch
from
220b5e9 to
2ac70f7
Compare
|
👍 |
|
Thank you Jules. |
wouterj
added a commit
that referenced
this pull request
Mar 5, 2016
This PR was merged into the 2.3 branch. Discussion ---------- [Form] fix 'data_class' option in EntityType `data_class` option in kind of overridden as it is not used in `EntityType` in favor of required `class` option. Commits ------- 2ac70f7 fix 'data_class' option in EntityType
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
data_classoption in kind of overridden as it is not used inEntityTypein favor of requiredclassoption.