-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cookbook][Bundles]fix yaml syntax #6269
Conversation
mhor
commented
Feb 13, 2016
Q | A |
---|---|
Doc fix? | yes |
New docs? | no |
Applies to | all |
👍 |
1 similar comment
👍 |
Technically, the YAML syntax was valid before, but we need this change so that Sphinx renders the code block successfully. However, the code block will still be rendered without any syntax highlighting as the code block type is |
@xabbuh, I changed block type to |
👍 Regarding the syntax, I think I will have to read the spec again and maybe we need to fix the Yaml component in regard of how to treat indicator characters. Thanks for pointing that out @mhor. |
Thinking about this again, I think we should change the type of the code block back to text as the output that you see in your terminal won't be coloured either. |
| Q | A | --------------- | ---- | Doc fix? | yes | New docs? | no | Applies to | all
I agree with you @xabbuh. I revert modification of |
Thank you @mhor. |
This PR was merged into the 2.3 branch. Discussion ---------- [Cookbook][Bundles]fix yaml syntax | Q | A | --------------- | ---- | Doc fix? | yes | New docs? | no | Applies to | all Commits ------- d25a312 fix yaml syntax
…ers (xabbuh) This PR was merged into the 3.1-dev branch. Discussion ---------- [Yaml] deprecate starting plain scalars with % characters | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | symfony/symfony-docs#6269, symfony/symfony-standard#426 | License | MIT | Doc PR | Commits ------- e883a4c deprecate starting plain scalars with % characters