Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo: signifcantly => significantly #6483

Closed
wants to merge 1 commit into from

Conversation

ifdattic
Copy link
Contributor

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets

@javiereguiluz
Copy link
Member

👍

@wouterj
Copy link
Member

wouterj commented Apr 18, 2016

Thanks Andrew!

wouterj added a commit that referenced this pull request Apr 18, 2016
This PR was submitted for the 3.0 branch but it was merged into the 2.3 branch instead (closes #6483).

Discussion
----------

Fix typo: signifcantly => significantly

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets |

Commits
-------

cfcd8df Fix typo: signifcantly => significantly
@wouterj
Copy link
Member

wouterj commented Apr 18, 2016

Btw, @javiereguiluz, do you have any idea why your comment shows up as 👍 in the API instead of :+1: (which is the case for other people's comments)? https://api.github.com/repos/symfony/symfony-docs/issues/6483/comments It breaks the core team voter of gh atm.

@wouterj wouterj closed this Apr 18, 2016
@javiereguiluz
Copy link
Member

@wouterj 😱 I don't know. I don't remember doing anything different.

@xabbuh
Copy link
Member

xabbuh commented Apr 19, 2016

@javiereguiluz How do you write your comments? Can this be caused by a saved reply? You can see that your vote is also shown as the icon when you edit your existing comment above.

@javiereguiluz
Copy link
Member

@xabbuh I write :+1: by hand (and I don't have any browser extension that modifies GitHub in any way).

@ifdattic
Copy link
Contributor Author

I also think this article could be improved a little bit. It has a small section about fixing performance issues, but in my opinion it's mostly "here take this, go figure it out yourself". Think that it could use the 80/20 approach an be more like "before investing a lot of time try this trick, it works most of the time". If adding that information the biggest question would be in that format: a paragraph of text, a commented out code, or something else.

In my opinion that should be noted are:

  • adding nfs type
  • changing session directory
  • nfs plugin for windows users

This video kind of provides the problem and solution (https://www.youtube.com/watch?v=Kn-O4jq0-r4)

/ping @javiereguiluz @wouterj @xabbuh

wouterj added a commit to wouterj/symfony-docs that referenced this pull request Apr 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants