Improved the docs for the DependencyInjection component #6504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
javiereguiluz
commented
Apr 20, 2016
javiereguiluz
commented
| Q | A |
|---|---|
| Doc fix? | no |
| New docs? | yes |
| Applies to | 2.3+ |
| Fixed tickets | - |
| First up is the class of a definition, this is the class of the object returned | ||
| when the service is requested from the container. | ||
| The first optional argument of the ``Definition`` class is the fully qualified | ||
| class name of the object returned when the service is get from the container:: |
|
I've fixed everything and made some rewords. Ready for another review. Thanks! |
| .. tip:: | ||
|
|
||
| Registering service definitions is so common that the container provides a | ||
| shortcut method called ``register()``: |
|
👍 |
| @@ -4,6 +4,9 @@ | |||
| Working with Container Service Definitions | |||
| ========================================== | |||
|
|
|||
| Service definitions are the instructions followed by the container to build a | |||
There was a problem hiding this comment.
Maybe "[...] are the instructions describing how the container should build a service. They are not the actual services used by our applications" ?
There was a problem hiding this comment.
Mucha better. Thanks
|
These old components articles are the ones that don't recieve a lot of attention, thanks for taking care of this one! |
wouterj
added a commit
that referenced
this pull request
May 5, 2016
…javiereguiluz) This PR was squashed before being merged into the 2.3 branch (closes #6504). Discussion ---------- Improved the docs for the DependencyInjection component | Q | A | ------------- | --- | Doc fix? | no | New docs? | yes | Applies to | 2.3+ | Fixed tickets | - Commits ------- 221ddf7 Improved the docs for the DependencyInjection component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.