-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add details about chmod +a vs setfacl #6518
Add details about chmod +a vs setfacl #6518
Conversation
@@ -261,6 +259,8 @@ If there are any issues, correct them now before moving on. | |||
|
|||
If this doesn't work, try adding ``-n`` option. | |||
|
|||
Note: setfacl isn't available on NFS mount points. However, setting cache and logs over NFS is strongly not recommanded for performance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should use a proper note with the .. note
directive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok added
@@ -261,6 +259,11 @@ If there are any issues, correct them now before moving on. | |||
|
|||
If this doesn't work, try adding ``-n`` option. | |||
|
|||
.. note:: | |||
|
|||
setfacl isn't available on NFS mount points. However, setting cache and logs over NFS is strongly not recommanded for performance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not recommended
for
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, fixed
called ``setfacl``. You may need to `enable ACL support`_ on your partition | ||
and install setfacl before using it (as is the case with Ubuntu). This | ||
and install setfacl before using it (as is the case with old versions of Ubuntu). This |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which versions of Ubuntu are affected by this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just know I didn't have to do it using 14.04 (released in April 2014) and 16.04 (current) so the message is out of date for current versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should then simply remove this note. People using even older versions will very likely have other issues too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I didn't want to be too radical so I first kept it, but you're right.
Done.
👍 |
This PR was squashed before being merged into the 2.3 branch (closes #6518). Discussion ---------- Add details about chmod +a vs setfacl | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | no chmod +a seems to be a MacOS X non standard feature so it's useless to ask everyone to try it before setfacl. Linux users should directly go for it (Internet is full of comments of people asking how to chmod +a on Ubuntu or CentOS). Add also informations about NFS and setfacl: it's a common issue when deploying on production. Commits ------- f70c6c0 Add details about chmod +a vs setfacl
Thanks @pasdeloup for the nice changes, detailed PR description and quick reactions! |
chmod +a seems to be a MacOS X non standard feature so it's useless to ask everyone to try it before setfacl. Linux users should directly go for it (Internet is full of comments of people asking how to chmod +a on Ubuntu or CentOS).
Add also informations about NFS and setfacl: it's a common issue when deploying on production.