Replace property_accessor by property_access #6545
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Property accessor service name is `property_accessor` but configuration key is `property_access`. IMHO, to avoid confusion both should be the same. But for the moment, I amend the documentation to reflect the actual mapping.
| @@ -1268,7 +1268,7 @@ for a given key. The logs are made to the ``translation`` channel and at the | |||
| ``debug`` for level for keys where there is a translation in the fallback | |||
| locale and the ``warning`` level if there is no translation to use at all. | |||
|
|
|||
| property_accessor | |||
| property_access | |||
| ~~~~~~~~~~~~~~~~~ | |||
There was a problem hiding this comment.
Can you shorten this line by two characters too?
|
👍 |
|
Sorry, fixed! |
|
Thanks for the PR & quick actions Julien! |
wouterj
added a commit
that referenced
this pull request
May 13, 2016
This PR was submitted for the 3.0 branch but it was merged into the 2.7 branch instead (closes #6545). Discussion ---------- Replace property_accessor by property_access Property accessor service name is `property_accessor` but configuration key is `property_access`. IMHO, to avoid confusion both should be the same. But for the moment, I amend the documentation to reflect the actual mapping. Commits ------- 592996c Replace property_accessor by property_access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Property accessor service name is
property_accessorbut configuration key isproperty_access.IMHO, to avoid confusion both should be the same. But for the moment, I amend the documentation to reflect the actual mapping.