Make ClockMock Tests\\ namespace matching less specific #6546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
teohhanhui
commented
May 9, 2016
•
teohhanhui
commented
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | 2.8+ |
| Fixed tickets | N/A |
|
Thanks @teohhanhui, it looks great this way! |
wouterj
added a commit
that referenced
this pull request
May 13, 2016
…ohhanhui) This PR was merged into the 2.8 branch. Discussion ---------- Make ClockMock Tests\\ namespace matching less specific | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.8+ | Fixed tickets | N/A Commits ------- 2d8f2ec Make ClockMock Tests\\ namespace matching less specific
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
May 30, 2016
…egin with Tests\\ (teohhanhui) This PR was submitted for the 2.8 branch but it was merged into the 3.2-dev branch instead (closes #18726). Discussion ---------- [PhpUnitBridge] Make ClockMock match namespaces that begin with Tests\\ | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes? | New feature? | no | BC breaks? | no? | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | symfony/symfony-docs#6546 See symfony/symfony-standard#969 Commits ------- 2630c13 [PhpUnitBridge] Make ClockMock match namespaces that begin with Tests\\
|
@wouterj Heads up, the related PR symfony/symfony#18726 was merged into master (3.2) so perhaps this should be reverted? |
| @@ -207,10 +207,10 @@ Troubleshooting | |||
| ~~~~~~~~~~~~~~~ | |||
|
|
|||
| The ``@group time-sensitive`` works "by convention" and assumes that the | |||
| namespace of the tested class can be obtained just by removing the ``\Tests\`` | |||
| namespace of the tested class can be obtained just by removing the ``Tests\`` | |||
There was a problem hiding this comment.
@teohhanhui This is the only change that must be revert, right? The fixes below are still valid if I don't miss anything.
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Jun 3, 2016
…in with Tests\\ (teohhanhui) This PR was merged into the 3.2-dev branch. Discussion ---------- [PhpUnitBridge] Make DnsMock match namespaces that begin with Tests\\ | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes? | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | symfony/symfony-docs#6546 Related to symfony/symfony-standard#969 Commits ------- d043305 [PhpUnitBridge] Make DnsMock match namespaces that begin with Tests\\
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.