Typo fix in the Serializer deserialization example for existing object #6552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Whoa, very nice catch Artem! Thanks for submitting this fix. |
wouterj
added a commit
that referenced
this pull request
May 13, 2016
…ting object (fre5h)
This PR was merged into the 2.7 branch.
Discussion
----------
Typo fix in the Serializer deserialization example for existing object
| Q | A
| ------------- | ---
| Doc fix? | yes
| New docs? | no
| Applies to | 2.7+
| Fixed tickets | N/A
Just found a small typo in the comment with result values of deserialization. As the init value of the `age` of the `person` is 99, then after deserializing the existing `person` object it is 69. But in comment it is still 99 `// $jsonContent contains {"name":"foo","age":99,"sportsman":false}`
Commits
-------
44ecd19 Typo fix in the Serializer deserialization example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just found a small typo in the comment with result values of deserialization. As the init value of the
ageof thepersonis 99, then after deserializing the existingpersonobject it is 69. But in comment it is still 99// $jsonContent contains {"name":"foo","age":99,"sportsman":false}