Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show label & set correct value in Symfony 3.X #6573

Closed
wants to merge 2 commits into from
Closed

Show label & set correct value in Symfony 3.X #6573

wants to merge 2 commits into from

Conversation

pbowyer
Copy link
Contributor

@pbowyer pbowyer commented May 16, 2016

At some point in Symfony history the key/value pairs switched orders, so the friendly label now has to be the key of the array. This change fixes the example.

At some point in Symfony history the key/value pairs switched orders, so the friendly label now has to be the key of the array. This change fixes the example.
@xabbuh
Copy link
Member

xabbuh commented May 21, 2016

Good catch @pbowyer. Seems like we missed this when working on #5179. Can you also add the choices_as_values options and set it to true so that we can merge your PR into the 2.7 branch?

@celdia
Copy link

celdia commented May 21, 2016

Hello @xabbuh . Why would you like to add the choices_as_values options. This options does exist in Symfony 3.x. Sorry I'm newcommer, I have need more explications.

@xabbuh
Copy link
Member

xabbuh commented May 21, 2016

@celdia We need to fix the docs for the 2.7 branch too. But on that version you add to use the choices_as_values options to let the choice type know that you swapped choices and labels.

@HeahDude
Copy link
Contributor

Closing as fixed by #7940. Thanks!

@HeahDude HeahDude closed this Jul 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants